ansible-personal/roles/common/tasks/firewall_Ubuntu.yml

---
- name: Install firewalld and deps
  when: ansible_distribution_version is version_compare('15.04', '>=')
  apt: pkg={{ item }} state=present
  loop:
    - firewalld
    - tidy
  tags:
    - packages
    - firewall

- name: Copy firewalld public zone file
  when: ansible_distribution_version is version_compare('15.04', '>=')
  template: src=public.xml.j2 dest=/etc/firewalld/zones/public.xml owner=root mode=0600
  tags: firewall

- name: Format public.xml firewalld zone file
  when: ansible_distribution_version is version_compare('15.04', '>=')
  command: tidy -xml -iq -m -w 0 /etc/firewalld/zones/public.xml
  notify:
    - reload firewalld
  tags: firewall

# vim: set sw=2 ts=2:
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00			`---`
			`- name: Install firewalld and deps`
Use new syntax for Jinj2 filters that are used as tests Ansible 2.5.0 uses a new syntax for Jinja2 filters that are used as tests. See: https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.5.html 2018-03-21 20:17:21 +01:00			`when: ansible_distribution_version is version_compare('15.04', '>=')`
roles/common: Fix issues raised by ansible-lint [ANSIBLE0010] Package installs should not use latest 2017-12-29 19:11:55 +01:00			`apt: pkg={{ item }} state=present`
Update with_items loops to use new-ish "loop" keyword Ansible 2.4 and 2.5 are moving away from specialized loop functions and the old syntax will eventually be deprecated and removed. I did not change the with_fileglob loops because I'm not sure about their syntax yet. See: https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html 2018-04-02 14:52:51 +02:00			`loop:`
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00			`- firewalld`
			`- tidy`
roles/common: Use dynamic include_tasks for firewall Use dynamic includes instead of static imports when you are running tasks conditionally or using variable interpolation. The down side is that you need to then tag the parent task as well as all child tasks, as tags only apply to children of statically imported tasks. 2018-04-25 17:58:31 +02:00			`tags:`
			`- packages`
			`- firewall`
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00
			`- name: Copy firewalld public zone file`
Use new syntax for Jinj2 filters that are used as tests Ansible 2.5.0 uses a new syntax for Jinja2 filters that are used as tests. See: https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.5.html 2018-03-21 20:17:21 +01:00			`when: ansible_distribution_version is version_compare('15.04', '>=')`
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00			`template: src=public.xml.j2 dest=/etc/firewalld/zones/public.xml owner=root mode=0600`
roles/common: Use dynamic include_tasks for firewall Use dynamic includes instead of static imports when you are running tasks conditionally or using variable interpolation. The down side is that you need to then tag the parent task as well as all child tasks, as tags only apply to children of statically imported tasks. 2018-04-25 17:58:31 +02:00			`tags: firewall`
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00
			`- name: Format public.xml firewalld zone file`
Use new syntax for Jinj2 filters that are used as tests Ansible 2.5.0 uses a new syntax for Jinja2 filters that are used as tests. See: https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.5.html 2018-03-21 20:17:21 +01:00			`when: ansible_distribution_version is version_compare('15.04', '>=')`
roles/common: Use command module instead of shell You should only use the "shell" module when you need shell functions like flow control and redirects. Also, the "command" module is safer because it is not affected by the user's environment. 2017-11-04 23:49:03 +01:00			`command: tidy -xml -iq -m -w 0 /etc/firewalld/zones/public.xml`
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00			`notify:`
roles/common: Reload firewalld instead of restart There is no need to bounce the service, just reload it. 2017-11-02 17:58:15 +01:00			`- reload firewalld`
roles/common: Use dynamic include_tasks for firewall Use dynamic includes instead of static imports when you are running tasks conditionally or using variable interpolation. The down side is that you need to then tag the parent task as well as all child tasks, as tags only apply to children of statically imported tasks. 2018-04-25 17:58:31 +02:00			`tags: firewall`
roles/common: Add missing vim modelines 2018-04-25 17:55:22 +02:00
			`# vim: set sw=2 ts=2:`