ansible-personal/roles/common/tasks/firewall_Ubuntu.yml

---
- name: Install firewalld and deps
  when: ansible_distribution_version | version_compare('15.04', '>=')
  apt: pkg={{ item }} state=present
  with_items:
    - firewalld
    - tidy
  tags: packages

- name: Copy firewalld public zone file
  when: ansible_distribution_version | version_compare('15.04', '>=')
  template: src=public.xml.j2 dest=/etc/firewalld/zones/public.xml owner=root mode=0600

- name: Format public.xml firewalld zone file
  when: ansible_distribution_version | version_compare('15.04', '>=')
  command: tidy -xml -iq -m -w 0 /etc/firewalld/zones/public.xml
  notify:
    - reload firewalld
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00			`---`
			`- name: Install firewalld and deps`
Use Ansible's version_compare instead of doing math on strings I'm surprised this worked all these years actually. Since Ansible version 1.6 it has been possible to use the version_compare filter instead of doing math logic on strings. See: https://docs.ansible.com/ansible/playbooks_tests.html 2016-12-20 14:04:47 +01:00			`when: ansible_distribution_version \| version_compare('15.04', '>=')`
roles/common: Fix issues raised by ansible-lint [ANSIBLE0010] Package installs should not use latest 2017-12-29 19:11:55 +01:00			`apt: pkg={{ item }} state=present`
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00			`with_items:`
			`- firewalld`
			`- tidy`
Add 'packages' tag to any task doing package stuff For idempotence we need to run all apt-related tasks, like editing source files, adding keys, installing packages, etc, when running the 'packages' tag. 2016-08-14 15:33:48 +02:00			`tags: packages`
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00
			`- name: Copy firewalld public zone file`
Use Ansible's version_compare instead of doing math on strings I'm surprised this worked all these years actually. Since Ansible version 1.6 it has been possible to use the version_compare filter instead of doing math logic on strings. See: https://docs.ansible.com/ansible/playbooks_tests.html 2016-12-20 14:04:47 +01:00			`when: ansible_distribution_version \| version_compare('15.04', '>=')`
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00			`template: src=public.xml.j2 dest=/etc/firewalld/zones/public.xml owner=root mode=0600`

			`- name: Format public.xml firewalld zone file`
Use Ansible's version_compare instead of doing math on strings I'm surprised this worked all these years actually. Since Ansible version 1.6 it has been possible to use the version_compare filter instead of doing math logic on strings. See: https://docs.ansible.com/ansible/playbooks_tests.html 2016-12-20 14:04:47 +01:00			`when: ansible_distribution_version \| version_compare('15.04', '>=')`
roles/common: Use command module instead of shell You should only use the "shell" module when you need shell functions like flow control and redirects. Also, the "command" module is safer because it is not affected by the user's environment. 2017-11-04 23:49:03 +01:00			`command: tidy -xml -iq -m -w 0 /etc/firewalld/zones/public.xml`
roles/common: Separate firewalld tasks for Ubuntu and Debian Signed-off-by: Alan Orth <alan.orth@gmail.com> 2015-08-23 11:06:25 +02:00			`notify:`
roles/common: Reload firewalld instead of restart There is no need to bounce the service, just reload it. 2017-11-02 17:58:15 +01:00			`- reload firewalld`