alanorth/cgspace-java-helpers
1
0
Fork 0
mirror of https://github.com/ilri/cgspace-java-helpers.git synced 2024-11-27 00:58:19 +01:00
Code Issues Projects Releases Wiki Activity

Add TODO about using try-with-resource

Browse Source 
This would automatically close the BufferedReader after we are done
with it, but it also means that the JSON object we create is lost
when we exit the try() scope...

See: https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
This commit is contained in:
Alan Orth 2020-07-31 22:25:38 +03:00
parent af708933b2
commit 9089ffb66f
Signed by: alanorth
GPG Key ID: 0FB860CC9C45B1B9
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/main/java/org/cgiar/cgspace/ctasks/CountryCodeTagger.java
View File

@ -72,6 +72,7 @@ public class CountryCodeTagger extends AbstractCurationTask
} else { } else {
Gson gson = new Gson(); Gson gson = new Gson();
// TODO: convert to try: https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
BufferedReader reader = new BufferedReader(new InputStreamReader(this.getClass().getResourceAsStream(isocodesJsonPath))); BufferedReader reader = new BufferedReader(new InputStreamReader(this.getClass().getResourceAsStream(isocodesJsonPath)));
CountriesVocabulary isocodesCountriesJson = gson.fromJson(reader, CountriesVocabulary.class); CountriesVocabulary isocodesCountriesJson = gson.fromJson(reader, CountriesVocabulary.class);
reader.close(); reader.close();