roles/mariadb: update task syntax for mariadb play

roles/common/tasks/fail2ban.yml

@@ -1,7 +1,6 @@
 ---
 - name: Install fail2ban
-  when:
-    - ansible_distribution_major_version is version('11', '>=')
+  when: ansible_distribution_major_version is version('11', '>=')
   ansible.builtin.package:
     name:
       - fail2ban

roles/mariadb/tasks/main.yml

@@ -16,6 +16,7 @@
     - mariadb
 
 - name: Download MariaDB package signing key
+  when: not mariadb_signing_key_stat.stat.exists
   ansible.builtin.get_url:
     url: https://mariadb.org/mariadb_release_signing_key.asc
     dest: /etc/apt/keyrings/mariadb_release_signing_key.asc
@@ -23,7 +24,6 @@
     group: root
     mode: "0644"
   register: download_mariadb_signing_key
-  when: not mariadb_signing_key_stat.stat.exists
   tags:
     - packages
     - mariadb
@@ -40,9 +40,9 @@
     - mariadb
 
 - name: Update apt cache
+  when: (download_mariadb_signing_key.status_code is defined and download_mariadb_signing_key.status_code == 200) or add_mariadb_apt_repository is changed
   ansible.builtin.apt: # noqa no-handler
     update_cache: true
-  when: (download_mariadb_signing_key.status_code is defined and download_mariadb_signing_key.status_code == 200) or add_mariadb_apt_repository is changed
   tags:
     - packages
     - mariadb
@@ -87,16 +87,17 @@
 
 # See: https://docs.ansible.com/ansible/latest/collections/community/mysql/mysql_db_module.html
 - name: Create MariaDB database(s)
+  when: mariadb_databases is defined
   community.mysql.mysql_db:
     db: "{{ item.name }}"
     state: present
     encoding: utf8mb4
     login_unix_socket: "{{ mariadb_login_unix_socket }}"
   loop: "{{ mariadb_databases }}"
-  when: mariadb_databases is defined
   tags: mariadb
 
 - name: Create MariaDB user(s)
+  when: mariadb_databases is defined
   community.mysql.mysql_user:
     name: "{{ item.user }}"
     password: "{{ item.pass }}"
@@ -105,7 +106,6 @@
     state: present
     login_unix_socket: "{{ mariadb_login_unix_socket }}"
   loop: "{{ mariadb_databases }}"
-  when: mariadb_databases is defined
   tags: mariadb
 
 # vim: set ts=2 sw=2: