roles/common: simplify firewall tasks

Apply firewall tag to included tasks, then we don't need to use a
block.
This commit is contained in:
Alan Orth 2025-01-27 22:30:50 +03:00
parent b873af004a
commit d6e060d3af
Signed by: alanorth
GPG Key ID: 0FB860CC9C45B1B9
3 changed files with 205 additions and 201 deletions

View File

@ -1,12 +1,20 @@
--- ---
- name: Configure firewall (Debian) - name: Configure firewall (Debian)
ansible.builtin.include_tasks: firewall_Debian.yml
when: ansible_distribution == 'Debian' when: ansible_distribution == 'Debian'
ansible.builtin.include_tasks:
file: firewall_Debian.yml
apply:
tags:
- firewall
tags: firewall tags: firewall
- name: Configure firewall (Ubuntu) - name: Configure firewall (Ubuntu)
ansible.builtin.include_tasks: firewall_Ubuntu.yml
when: ansible_distribution == 'Ubuntu' when: ansible_distribution == 'Ubuntu'
ansible.builtin.include_tasks:
file: firewall_Ubuntu.yml
apply:
tags:
- firewall
tags: firewall tags: firewall

View File

@ -1,7 +1,6 @@
--- ---
# Debian 11+ will use nftables directly, with no firewalld. # Debian 11+ will use nftables directly, with no firewalld.
- block:
- name: Install Debian firewall packages - name: Install Debian firewall packages
when: ansible_distribution_major_version is version('11', '>=') when: ansible_distribution_major_version is version('11', '>=')
ansible.builtin.package: ansible.builtin.package:
@ -110,6 +109,5 @@
- ansible.builtin.include_tasks: fail2ban.yml - ansible.builtin.include_tasks: fail2ban.yml
when: when:
- ansible_distribution_major_version is version('9', '>=') - ansible_distribution_major_version is version('9', '>=')
tags: firewall
# vim: set sw=2 ts=2: # vim: set sw=2 ts=2:

View File

@ -1,7 +1,6 @@
--- ---
# Ubuntu 20.04 will use nftables directly, with no firewalld. # Ubuntu 20.04 will use nftables directly, with no firewalld.
- block:
- name: Install Ubuntu firewall packages - name: Install Ubuntu firewall packages
when: ansible_distribution_version is version('20.04', '>=') when: ansible_distribution_version is version('20.04', '>=')
ansible.builtin.package: ansible.builtin.package:
@ -109,6 +108,5 @@
- ansible.builtin.include_tasks: fail2ban.yml - ansible.builtin.include_tasks: fail2ban.yml
when: when:
- ansible_distribution_version is version('16.04', '>=') - ansible_distribution_version is version('16.04', '>=')
tags: firewall
# vim: set sw=2 ts=2: # vim: set sw=2 ts=2: