roles/common: Use dynamic include_tasks for firewall

Use dynamic includes instead of static imports when you are running
tasks conditionally or using variable interpolation. The down side
is that you need to then tag the parent task as well as all child
tasks, as tags only apply to children of statically imported tasks.
This commit is contained in:
Alan Orth 2018-04-25 18:58:31 +03:00
parent a044fd2f55
commit ab27caf877
Signed by: alanorth
GPG Key ID: 0FB860CC9C45B1B9
3 changed files with 12 additions and 4 deletions

View File

@ -5,16 +5,20 @@
loop:
- firewalld
- tidy
tags: packages
tags:
- packages
- firewall
- name: Copy firewalld public zone file
when: ansible_distribution_major_version is version_compare('8', '>=')
template: src=public.xml.j2 dest=/etc/firewalld/zones/public.xml owner=root mode=0600
tags: firewall
- name: Format public.xml firewalld zone file
when: ansible_distribution_major_version is version_compare('8', '>=')
command: tidy -xml -iq -m -w 0 /etc/firewalld/zones/public.xml
notify:
- reload firewalld
tags: firewall
# vim: set sw=2 ts=2:

View File

@ -5,16 +5,20 @@
loop:
- firewalld
- tidy
tags: packages
tags:
- packages
- firewall
- name: Copy firewalld public zone file
when: ansible_distribution_version is version_compare('15.04', '>=')
template: src=public.xml.j2 dest=/etc/firewalld/zones/public.xml owner=root mode=0600
tags: firewall
- name: Format public.xml firewalld zone file
when: ansible_distribution_version is version_compare('15.04', '>=')
command: tidy -xml -iq -m -w 0 /etc/firewalld/zones/public.xml
notify:
- reload firewalld
tags: firewall
# vim: set sw=2 ts=2:

View File

@ -18,12 +18,12 @@
tags: packages
- name: Configure firewall
import_tasks: firewall_Debian.yml
include_tasks: firewall_Debian.yml
when: ansible_distribution == 'Debian'
tags: firewall
- name: Configure firewall
import_tasks: firewall_Ubuntu.yml
include_tasks: firewall_Ubuntu.yml
when: ansible_distribution == 'Ubuntu'
tags: firewall