roles: use fully qualified module names

roles/php-fpm/tasks/Debian_10.yml

@@ -2,7 +2,7 @@
 
 - block:
   - name: Set php-fpm packages
-    set_fact:
+    ansible.builtin.set_fact:
       php_fpm_packages:
         - php-fpm
         # for WordPress
@@ -11,22 +11,22 @@
         - php-curl
 
   - name: Install php-fpm and deps
-    apt: name={{ php_fpm_packages }} state=present update_cache=yes
+    ansible.builtin.apt: name={{ php_fpm_packages }} state=present update_cache=yes
 
   # only copy php-fpm config for vhosts that need WordPress or PHP
   - name: Copy php-fpm pool config
-    template: src=php7.3-pool.conf.j2 dest=/etc/php/7.3/fpm/pool.d/{{ item.domain_name }}.conf owner=root group=root mode=0644
+    ansible.builtin.template: src=php7.3-pool.conf.j2 dest=/etc/php/7.3/fpm/pool.d/{{ item.domain_name }}.conf owner=root group=root mode=0644
     loop: "{{ nginx_vhosts }}"
     when: (item.has_wordpress is defined and item.has_wordpress) or (item.needs_php is defined and item.needs_php)
     notify: reload php7.3-fpm
 
   - name: Remove default www pool
-    file: path=/etc/php/7.3/fpm/pool.d/www.conf state=absent
+    ansible.builtin.file: path=/etc/php/7.3/fpm/pool.d/www.conf state=absent
     notify: reload php7.3-fpm
 
   # re-configure php.ini
   - name: Update php.ini
-    template: src=php7.3-php.ini.j2 dest=/etc/php/7.3/fpm/php.ini owner=root group=root mode=0644
+    ansible.builtin.template: src=php7.3-php.ini.j2 dest=/etc/php/7.3/fpm/php.ini owner=root group=root mode=0644
     notify: reload php7.3-fpm
 
   tags: php-fpm

roles/php-fpm/tasks/Ubuntu_18.04.yml

@@ -2,7 +2,7 @@
 
 - block:
   - name: Set php-fpm packages
-    set_fact:
+    ansible.builtin.set_fact:
       php_fpm_packages:
         - php-fpm
         # for WordPress
@@ -11,22 +11,22 @@
         - php-curl
 
   - name: Install php-fpm and deps
-    apt: name={{ php_fpm_packages }} state=present update_cache=yes
+    ansible.builtin.apt: name={{ php_fpm_packages }} state=present update_cache=yes
 
   # only copy php-fpm config for vhosts that need WordPress or PHP
   - name: Copy php-fpm pool config
-    template: src=php7.2-pool.conf.j2 dest=/etc/php/7.2/fpm/pool.d/{{ item.domain_name }}.conf owner=root group=root mode=0644
+    ansible.builtin.template: src=php7.2-pool.conf.j2 dest=/etc/php/7.2/fpm/pool.d/{{ item.domain_name }}.conf owner=root group=root mode=0644
     loop: "{{ nginx_vhosts }}"
     when: (item.has_wordpress is defined and item.has_wordpress) or (item.needs_php is defined and item.needs_php)
     notify: reload php7.2-fpm
 
   - name: Remove default www pool
-    file: path=/etc/php/7.2/fpm/pool.d/www.conf state=absent
+    ansible.builtin.file: path=/etc/php/7.2/fpm/pool.d/www.conf state=absent
     notify: reload php7.2-fpm
 
   # re-configure php.ini
   - name: Update php.ini
-    template: src=php7.2-php.ini.j2 dest=/etc/php/7.2/fpm/php.ini owner=root group=root mode=0644
+    ansible.builtin.template: src=php7.2-php.ini.j2 dest=/etc/php/7.2/fpm/php.ini owner=root group=root mode=0644
     notify: reload php7.2-fpm
 
   tags: php-fpm

roles/php-fpm/tasks/Ubuntu_20.04.yml

@@ -2,7 +2,7 @@
 
 - block:
   - name: Set php-fpm packages
-    set_fact:
+    ansible.builtin.set_fact:
       php_fpm_packages:
         - php7.4-fpm
         # for WordPress
@@ -12,22 +12,22 @@
         - php7.4-xml
 
   - name: Install php-fpm and deps
-    apt: name={{ php_fpm_packages }} state=present update_cache=yes
+    ansible.builtin.apt: name={{ php_fpm_packages }} state=present update_cache=yes
 
   # only copy php-fpm config for vhosts that need WordPress or PHP
   - name: Copy php-fpm pool config
-    template: src=php7.4-pool.conf.j2 dest=/etc/php/7.4/fpm/pool.d/{{ item.domain_name }}.conf owner=root group=root mode=0644
+    ansible.builtin.template: src=php7.4-pool.conf.j2 dest=/etc/php/7.4/fpm/pool.d/{{ item.domain_name }}.conf owner=root group=root mode=0644
     loop: "{{ nginx_vhosts }}"
     when: (item.has_wordpress is defined and item.has_wordpress) or (item.needs_php is defined and item.needs_php)
     notify: reload php7.4-fpm
 
   - name: Remove default www pool
-    file: path=/etc/php/7.4/fpm/pool.d/www.conf state=absent
+    ansible.builtin.file: path=/etc/php/7.4/fpm/pool.d/www.conf state=absent
     notify: reload php7.4-fpm
 
   # re-configure php.ini
   - name: Update php.ini
-    template: src=php7.4-php.ini.j2 dest=/etc/php/7.4/fpm/php.ini owner=root group=root mode=0644
+    ansible.builtin.template: src=php7.4-php.ini.j2 dest=/etc/php/7.4/fpm/php.ini owner=root group=root mode=0644
     notify: reload php7.4-fpm
 
   tags: php-fpm

roles/php-fpm/tasks/main.yml

@@ -10,40 +10,40 @@
 #
 # See: https://stackoverflow.com/a/31896249
 - name: Check if any vhost needs WordPress
-  set_fact:
+  ansible.builtin.set_fact:
     install_php: True
   when: "nginx_vhosts | selectattr('has_wordpress', 'defined') | selectattr('has_wordpress', 'equalto', True) | list | length > 0"
 
 # Legacy, was only for Piwik, but leaving for now.
 - name: Check if any vhost needs PHP
-  set_fact:
+  ansible.builtin.set_fact:
     install_php: True
   when: "nginx_vhosts | selectattr('needs_php', 'defined') | selectattr('needs_php', 'equalto', True) | list | length > 0"
 
 # If install_php has not been set, then we assume no vhosts need PHP. This is
 # a bit hacky, but it's the closest we come to an if/then/else.
 - name: Set install_php to False
-  set_fact:
+  ansible.builtin.set_fact:
     install_php: False
   when: install_php is not defined
 
 - name: Configure php-fpm on Ubuntu 18.04
-  include_tasks: Ubuntu_18.04.yml
+  ansible.builtin.include_tasks: Ubuntu_18.04.yml
   when: ansible_distribution == 'Ubuntu' and ansible_distribution_version is version('18.04', '==') and install_php
   tags: php-fpm
 
 - name: Configure php-fpm on Debian 10
-  include_tasks: Debian_10.yml
+  ansible.builtin.include_tasks: Debian_10.yml
   when: ansible_distribution == 'Debian' and ansible_distribution_version is version('10', '==') and install_php
   tags: php-fpm
 
 - name: Configure php-fpm on Ubuntu 20.04
-  include_tasks: Ubuntu_20.04.yml
+  ansible.builtin.include_tasks: Ubuntu_20.04.yml
   when: ansible_distribution == 'Ubuntu' and ansible_distribution_version is version('20.04', '==') and install_php
   tags: php-fpm
 
 - name: Configure php-fpm on Debian 11
-  include_tasks: Ubuntu_20.04.yml
+  ansible.builtin.include_tasks: Ubuntu_20.04.yml
   when: ansible_distribution == 'Debian' and ansible_distribution_version is version('11', '==') and install_php
   tags: php-fpm