roles: use fully qualified module names

roles/common/handlers/main.yml

@@ -1,23 +1,23 @@
 ---
-# file: roles/common/handlers/main.yml
+# ansible.builtin.file: roles/common/handlers/main.yml
 
 - name: reload sshd
-  systemd: name={{ sshd_service_name }} state=reloaded
+  ansible.builtin.systemd: name={{ sshd_service_name }} state=reloaded
 
 - name: reload sysctl
   command: sysctl -p /etc/sysctl.conf
 
 - name: restart firewalld
-  systemd: name=firewalld state=restarted
+  ansible.builtin.systemd: name=firewalld state=restarted
 
 - name: reload systemd
-  systemd: daemon_reload=yes
+  ansible.builtin.systemd: daemon_reload=yes
 
 - name: restart nftables
-  systemd: name=nftables state=restarted
+  ansible.builtin.systemd: name=nftables state=restarted
 
 # 2021-09-28: note to self to keep fail2ban at the end, as handlers are executed
 # in the order they are defined, not in the order they are listed in the task's
 # notify statement and we must restart fail2ban after updating the firewall.
 - name: restart fail2ban
-  systemd: name=fail2ban state=restarted
+  ansible.builtin.systemd: name=fail2ban state=restarted

roles/common/tasks/cron-apt.yml

@@ -1,12 +1,12 @@
 ---
 
 - name: Configure cron-apt (config)
-  copy: src={{ item.src }} dest={{ item.dest }} mode={{ item.mode }} owner={{ item.owner }} group={{ item.group }}
+  ansible.builtin.copy: src={{ item.src }} dest={{ item.dest }} mode={{ item.mode }} owner={{ item.owner }} group={{ item.group }}
   loop:
     - { src: 'etc/cron-apt/config', dest: '/etc/cron-apt/config', mode: '0644', owner: 'root', group: 'root' }
     - { src: 'etc/cron-apt/3-download', dest: '/etc/cron-apt/action.d/3-download', mode: '0644', owner: 'root', group: 'root' }
 
 - name: Configure cron-apt (security)
-  template: src=security.sources.list.j2 dest=/etc/apt/security.sources.list mode=0644 owner=root group=root
+  ansible.builtin.template: src=security.sources.list.j2 dest=/etc/apt/security.sources.list mode=0644 owner=root group=root
 
 # vim: set ts=2 sw=2:

roles/common/tasks/fail2ban.yml

@@ -1,25 +1,25 @@
 ---
 
 - name: Configure fail2ban sshd filter
-  template: src=etc/fail2ban/jail.d/sshd.local.j2 dest=/etc/fail2ban/jail.d/sshd.local owner=root mode=0644
+  ansible.builtin.template: src=etc/fail2ban/jail.d/sshd.local.j2 dest=/etc/fail2ban/jail.d/sshd.local owner=root mode=0644
   notify: restart fail2ban
 
 - name: Configure fail2ban nginx filter
   when: "extra_fail2ban_filters is defined and 'nginx' in extra_fail2ban_filters"
-  template: src=etc/fail2ban/jail.d/nginx.local.j2 dest=/etc/fail2ban/jail.d/nginx.local owner=root mode=0644
+  ansible.builtin.template: src=etc/fail2ban/jail.d/nginx.local.j2 dest=/etc/fail2ban/jail.d/nginx.local owner=root mode=0644
   notify: restart fail2ban
 
 - name: Create fail2ban service override directory
-  file: path=/etc/systemd/system/fail2ban.service.d state=directory owner=root mode=0755
+  ansible.builtin.file: path=/etc/systemd/system/fail2ban.service.d state=directory owner=root mode=0755
 
 # See Arch Linux's example: https://wiki.archlinux.org/index.php/Fail2ban
 - name: Configure fail2ban service override
-  template: src=etc/systemd/system/fail2ban.service.d/override.conf.j2 dest=/etc/systemd/system/fail2ban.service.d/override.conf owner=root mode=0644
+  ansible.builtin.template: src=etc/systemd/system/fail2ban.service.d/override.conf.j2 dest=/etc/systemd/system/fail2ban.service.d/override.conf owner=root mode=0644
   notify:
     - reload systemd
     - restart fail2ban
 
 - name: Start and enable fail2ban service
-  systemd: name=fail2ban state=started enabled=yes
+  ansible.builtin.systemd: name=fail2ban state=started enabled=yes
 
 # vim: set sw=2 ts=2:

roles/common/tasks/firewall_Debian.yml

@@ -5,7 +5,7 @@
 - block:
   - name: Set Debian firewall packages
     when: ansible_distribution_major_version is version('10', '<=')
-    set_fact:
+    ansible.builtin.set_fact:
       debian_firewall_packages:
         - firewalld
         - tidy
@@ -14,7 +14,7 @@
 
   - name: Set Debian firewall packages
     when: ansible_distribution_major_version is version('11', '>=')
-    set_fact:
+    ansible.builtin.set_fact:
       debian_firewall_packages:
         - fail2ban
         - libnet-ip-perl # for aggregate-cidr-addresses.pl
@@ -23,26 +23,26 @@
         - curl # for nftables update scripts
 
   - name: Install firewall packages
-    apt: pkg={{ debian_firewall_packages }} state=present cache_valid_time=3600
+    ansible.builtin.apt: pkg={{ debian_firewall_packages }} state=present cache_valid_time=3600
 
   - name: Remove iptables on newer Debian
     when: ansible_distribution_major_version is version('11', '>=')
-    apt: pkg=iptables state=absent
+    ansible.builtin.apt: pkg=iptables state=absent
 
   - name: Copy nftables.conf
     when: ansible_distribution_major_version is version('11', '>=')
-    template: src=nftables.conf.j2 dest=/etc/nftables.conf owner=root mode=0644
+    ansible.builtin.template: src=nftables.conf.j2 dest=/etc/nftables.conf owner=root mode=0644
     notify:
       - restart nftables
       - restart fail2ban
 
   - name: Create /etc/nftables extra config directory
     when: ansible_distribution_major_version is version('11', '>=')
-    file: path=/etc/nftables state=directory owner=root mode=0755
+    ansible.builtin.file: path=/etc/nftables state=directory owner=root mode=0755
 
   - name: Copy extra nftables configuration files
     when: ansible_distribution_major_version is version('11', '>=')
-    copy: src={{ item.src }} dest=/etc/nftables/{{ item.src }} owner=root group=root mode=0644 force={{ item.force }}
+    ansible.builtin.copy: src={{ item.src }} dest=/etc/nftables/{{ item.src }} owner=root group=root mode=0644 force={{ item.force }}
     loop:
       - { src: "spamhaus-ipv4.nft", force: "no" }
       - { src: "spamhaus-ipv6.nft", force: "no" }
@@ -55,7 +55,7 @@
 
   - name: Use iptables backend in firewalld
     when: ansible_distribution_major_version is version('10', '==')
-    lineinfile:
+    ansible.builtin.lineinfile:
       dest: /etc/firewalld/firewalld.conf
       regexp: '^FirewallBackend=nftables$'
       line: 'FirewallBackend=iptables'
@@ -68,7 +68,7 @@
 # See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931722
   - name: Use individual iptables calls
     when: ansible_distribution_major_version is version('10', '==')
-    lineinfile:
+    ansible.builtin.lineinfile:
       dest: /etc/firewalld/firewalld.conf
       regexp: '^IndividualCalls=no$'
       line: 'IndividualCalls=yes'
@@ -78,7 +78,7 @@
 
   - name: Copy firewalld public zone file
     when: ansible_distribution_major_version is version('10', '<=')
-    template: src=public.xml.j2 dest=/etc/firewalld/zones/public.xml owner=root mode=0600
+    ansible.builtin.template: src=public.xml.j2 dest=/etc/firewalld/zones/public.xml owner=root mode=0600
 
   - name: Format public.xml firewalld zone file
     when: ansible_distribution_major_version is version('10', '<=')
@@ -89,7 +89,7 @@
 
   - name: Copy firewalld ipsets of abusive IPs
     when: ansible_distribution_major_version is version('10', '<=')
-    copy: src={{ item }} dest=/etc/firewalld/ipsets/{{ item }} owner=root group=root mode=0600
+    ansible.builtin.copy: src={{ item }} dest=/etc/firewalld/ipsets/{{ item }} owner=root group=root mode=0600
     loop:
       - abusers-ipv4.xml
       - abusers-ipv6.xml
@@ -101,11 +101,11 @@
 
   - name: Copy Spamhaus firewalld update script
     when: ansible_distribution_version is version('10', '<=')
-    copy: src=update-spamhaus-lists.sh dest=/usr/local/bin/update-spamhaus-lists.sh mode=0755 owner=root group=root
+    ansible.builtin.copy: src=update-spamhaus-lists.sh dest=/usr/local/bin/update-spamhaus-lists.sh mode=0755 owner=root group=root
 
   - name: Copy Spamhaus firewalld systemd units
     when: ansible_distribution_version is version('10', '<=')
-    copy: src={{ item }} dest=/etc/systemd/system/{{ item }} mode=0644 owner=root group=root
+    ansible.builtin.copy: src={{ item }} dest=/etc/systemd/system/{{ item }} mode=0644 owner=root group=root
     loop:
         - update-spamhaus-lists.service
         - update-spamhaus-lists.timer
@@ -113,7 +113,7 @@
 
   - name: Copy Spamhaus nftables update scripts
     when: ansible_distribution_version is version('11', '>=')
-    copy: src={{ item }} dest=/usr/local/bin/{{ item }} mode=0755 owner=root group=root
+    ansible.builtin.copy: src={{ item }} dest=/usr/local/bin/{{ item }} mode=0755 owner=root group=root
     loop:
       - update-spamhaus-nftables.sh
       - aggregate-cidr-addresses.pl
@@ -121,7 +121,7 @@
 
   - name: Copy nftables systemd units
     when: ansible_distribution_version is version('11', '>=')
-    copy: src={{ item }} dest=/etc/systemd/system/{{ item }} mode=0644 owner=root group=root
+    ansible.builtin.copy: src={{ item }} dest=/etc/systemd/system/{{ item }} mode=0644 owner=root group=root
     loop:
         - update-spamhaus-nftables.service
         - update-spamhaus-nftables.timer
@@ -131,29 +131,29 @@
 
   # need to reload to pick up service/timer/environment changes
   - name: Reload systemd daemon
-    systemd: daemon_reload=yes
+    ansible.builtin.systemd: daemon_reload=yes
     when: spamhaus_firewalld_systemd_units is changed or
           nftables_systemd_units is changed
 
   - name: Start and enable Spamhaus firewalld update timer
     when: ansible_distribution_version is version('10', '<=')
-    systemd: name=update-spamhaus-lists.timer state=started enabled=yes
+    ansible.builtin.systemd: name=update-spamhaus-lists.timer state=started enabled=yes
     notify:
       - restart firewalld
       - restart fail2ban
 
   - name: Start and enable nftables update timers
     when: ansible_distribution_version is version('11', '>=')
-    systemd: name={{ item }} state=started enabled=yes
+    ansible.builtin.systemd: name={{ item }} state=started enabled=yes
     loop:
       - update-spamhaus-nftables.timer
       - update-abusech-nftables.timer
 
   - name: Start and enable nftables
     when: ansible_distribution_major_version is version('11', '>=')
-    systemd: name=nftables state=started enabled=yes
+    ansible.builtin.systemd: name=nftables state=started enabled=yes
 
-  - include_tasks: fail2ban.yml
+  - ansible.builtin.include_tasks: fail2ban.yml
     when: ansible_distribution_major_version is version('9', '>=')
   tags: firewall
 

roles/common/tasks/firewall_Ubuntu.yml

@@ -6,7 +6,7 @@
 - block:
   - name: Set Ubuntu firewall packages
     when: ansible_distribution_version is version('20.04', '<')
-    set_fact:
+    ansible.builtin.set_fact:
       ubuntu_firewall_packages:
         - firewalld
         - tidy
@@ -15,7 +15,7 @@
 
   - name: Set Ubuntu firewall packages
     when: ansible_distribution_version is version('20.04', '>=')
-    set_fact:
+    ansible.builtin.set_fact:
       ubuntu_firewall_packages:
         - fail2ban
         - libnet-ip-perl # for aggregate-cidr-addresses.pl
@@ -24,26 +24,26 @@
         - curl # for nftables update scripts
 
   - name: Install firewall packages
-    apt: pkg={{ ubuntu_firewall_packages }} state=present cache_valid_time=3600
+    ansible.builtin.apt: pkg={{ ubuntu_firewall_packages }} state=present cache_valid_time=3600
 
   - name: Remove ufw
     when: ansible_distribution_version is version('16.04', '>=')
-    apt: pkg=ufw state=absent
+    ansible.builtin.apt: pkg=ufw state=absent
 
   - name: Copy nftables.conf
     when: ansible_distribution_version is version('20.04', '>=')
-    template: src=nftables.conf.j2 dest=/etc/nftables.conf owner=root mode=0644
+    ansible.builtin.template: src=nftables.conf.j2 dest=/etc/nftables.conf owner=root mode=0644
     notify:
       - restart nftables
       - restart fail2ban
 
   - name: Create /etc/nftables extra config directory
     when: ansible_distribution_version is version('20.04', '>=')
-    file: path=/etc/nftables state=directory owner=root mode=0755
+    ansible.builtin.file: path=/etc/nftables state=directory owner=root mode=0755
 
   - name: Copy extra nftables configuration files
     when: ansible_distribution_version is version('20.04', '>=')
-    copy: src={{ item.src }} dest=/etc/nftables/{{ item.src }} owner=root group=root mode=0644 force={{ item.force }}
+    ansible.builtin.copy: src={{ item.src }} dest=/etc/nftables/{{ item.src }} owner=root group=root mode=0644 force={{ item.force }}
     loop:
       - { src: "spamhaus-ipv4.nft", force: "no" }
       - { src: "spamhaus-ipv6.nft", force: "no" }
@@ -56,7 +56,7 @@
 
   - name: Copy firewalld public zone file
     when: ansible_distribution_version is version('18.04', '<=')
-    template: src=public.xml.j2 dest=/etc/firewalld/zones/public.xml owner=root mode=0600
+    ansible.builtin.template: src=public.xml.j2 dest=/etc/firewalld/zones/public.xml owner=root mode=0600
 
   - name: Format public.xml firewalld zone file
     when: ansible_distribution_version is version('18.04', '<=')
@@ -67,7 +67,7 @@
 
   - name: Copy firewalld ipsets of abusive IPs
     when: ansible_distribution_version is version('18.04', '<=')
-    copy: src={{ item }} dest=/etc/firewalld/ipsets/{{ item }} owner=root group=root mode=0600
+    ansible.builtin.copy: src={{ item }} dest=/etc/firewalld/ipsets/{{ item }} owner=root group=root mode=0600
     loop:
       - abusers-ipv4.xml
       - abusers-ipv6.xml
@@ -79,11 +79,11 @@
 
   - name: Copy Spamhaus firewalld update script
     when: ansible_distribution_version is version('18.04', '<=')
-    copy: src=update-spamhaus-lists.sh dest=/usr/local/bin/update-spamhaus-lists.sh mode=0755 owner=root group=root
+    ansible.builtin.copy: src=update-spamhaus-lists.sh dest=/usr/local/bin/update-spamhaus-lists.sh mode=0755 owner=root group=root
 
   - name: Copy Spamhaus firewalld systemd units
     when: ansible_distribution_version is version('18.04', '<=')
-    copy: src={{ item }} dest=/etc/systemd/system/{{ item }} mode=0644 owner=root group=root
+    ansible.builtin.copy: src={{ item }} dest=/etc/systemd/system/{{ item }} mode=0644 owner=root group=root
     loop:
         - update-spamhaus-lists.service
         - update-spamhaus-lists.timer
@@ -91,7 +91,7 @@
 
   - name: Copy nftables update scripts
     when: ansible_distribution_version is version('20.04', '>=')
-    copy: src={{ item }} dest=/usr/local/bin/{{ item }} mode=0755 owner=root group=root
+    ansible.builtin.copy: src={{ item }} dest=/usr/local/bin/{{ item }} mode=0755 owner=root group=root
     loop:
       - update-spamhaus-nftables.sh
       - aggregate-cidr-addresses.pl
@@ -99,7 +99,7 @@
 
   - name: Copy nftables systemd units
     when: ansible_distribution_version is version('20.04', '>=')
-    copy: src={{ item }} dest=/etc/systemd/system/{{ item }} mode=0644 owner=root group=root
+    ansible.builtin.copy: src={{ item }} dest=/etc/systemd/system/{{ item }} mode=0644 owner=root group=root
     loop:
         - update-spamhaus-nftables.service
         - update-spamhaus-nftables.timer
@@ -109,29 +109,29 @@
 
   # need to reload to pick up service/timer/environment changes
   - name: Reload systemd daemon
-    systemd: daemon_reload=yes
+    ansible.builtin.systemd: daemon_reload=yes
     when: spamhaus_firewalld_systemd_units is changed or
           nftables_systemd_units is changed
 
   - name: Start and enable Spamhaus firewalld update timer
     when: ansible_distribution_version is version('18.04', '<=')
-    systemd: name=update-spamhaus-lists.timer state=started enabled=yes
+    ansible.builtin.systemd: name=update-spamhaus-lists.timer state=started enabled=yes
     notify:
       - restart firewalld
       - restart fail2ban
 
   - name: Start and enable nftables update timers
     when: ansible_distribution_version is version('20.04', '>=')
-    systemd: name={{ item }} state=started enabled=yes
+    ansible.builtin.systemd: name={{ item }} state=started enabled=yes
     loop:
       - update-spamhaus-nftables.timer
       - update-abusech-nftables.timer
 
   - name: Start and enable nftables
     when: ansible_distribution_version is version('20.04', '>=')
-    systemd: name=nftables state=started enabled=yes
+    ansible.builtin.systemd: name=nftables state=started enabled=yes
 
-  - include_tasks: fail2ban.yml
+  - ansible.builtin.include_tasks: fail2ban.yml
     when: ansible_distribution_version is version('16.04', '>=')
   tags: firewall
 

roles/common/tasks/main.yml

@@ -1,54 +1,54 @@
 ---
 - name: Import OS-specific variables
-  include_vars: "vars/{{ ansible_distribution }}.yml"
+  ansible.builtin.include_vars: "vars/{{ ansible_distribution }}.yml"
   tags: always
 
 - name: Configure network time
-  import_tasks: ntp.yml
+  ansible.builtin.import_tasks: ntp.yml
   tags: ntp
 
 - name: Install common packages
-  include_tasks: packages_Debian.yml
+  ansible.builtin.include_tasks: packages_Debian.yml
   when: ansible_distribution == 'Debian'
   tags: packages
 
 - name: Install common packages
-  include_tasks: packages_Ubuntu.yml
+  ansible.builtin.include_tasks: packages_Ubuntu.yml
   when: ansible_distribution == 'Ubuntu'
   tags: packages
 
 - name: Configure firewall
-  include_tasks: firewall_Debian.yml
+  ansible.builtin.include_tasks: firewall_Debian.yml
   when: ansible_distribution == 'Debian'
   tags: firewall
 
 - name: Configure firewall
-  include_tasks: firewall_Ubuntu.yml
+  ansible.builtin.include_tasks: firewall_Ubuntu.yml
   when: ansible_distribution == 'Ubuntu'
   tags: firewall
 
 - name: Configure secure shell daemon
-  import_tasks: sshd.yml
+  ansible.builtin.import_tasks: sshd.yml
   tags: sshd
 
 # containers identify as virtualization hosts, which makes this tricky, because we have actual Debian VM hosts!
 - name: Reconfigure /etc/sysctl.conf
   when: ansible_virtualization_role != 'host'
-  template: src=sysctl_{{ ansible_distribution }}.j2 dest=/etc/sysctl.conf owner=root group=root mode=0644
+  ansible.builtin.template: src=sysctl_{{ ansible_distribution }}.j2 dest=/etc/sysctl.conf owner=root group=root mode=0644
   notify:
     - reload sysctl
   tags: sysctl
 
 - name: Reconfigure /etc/rc.local
   when: ansible_distribution == 'Ubuntu' and ansible_distribution_version is version('19.04', '<=')
-  template: src=rc.local_Ubuntu.j2 dest=/etc/rc.local owner=root group=root mode=0755
+  ansible.builtin.template: src=rc.local_Ubuntu.j2 dest=/etc/rc.local owner=root group=root mode=0755
 
 - name: Set I/O scheduler
-  template: src=etc/udev/rules.d/60-scheduler.rules.j2 dest=/etc/udev/rules.d/60-scheduler.rules owner=root group=root mode=0644
+  ansible.builtin.template: src=etc/udev/rules.d/60-scheduler.rules.j2 dest=/etc/udev/rules.d/60-scheduler.rules owner=root group=root mode=0644
   tags: udev
 
 - name: Copy admin SSH keys
-  import_tasks: ssh-keys.yml
+  ansible.builtin.import_tasks: ssh-keys.yml
   tags: ssh-keys
 
 # vim: set sw=2 ts=2:

roles/common/tasks/ntp.yml

@@ -14,14 +14,14 @@
 - name: Install systemd-timesyncd
   when: (ansible_distribution == 'Ubuntu' and ansible_distribution_version is version('20.04', '==')) or
         (ansible_distribution == 'Debian' and ansible_distribution_version is version('11', '=='))
-  apt: name=systemd-timesyncd state=present cache_valid_time=3600
+  ansible.builtin.apt: name=systemd-timesyncd state=present cache_valid_time=3600
 
 - name: Start and enable systemd's NTP client
   when: ansible_service_mgr == 'systemd'
-  systemd: name=systemd-timesyncd state=started enabled=yes
+  ansible.builtin.systemd: name=systemd-timesyncd state=started enabled=yes
 
 - name: Uninstall ntp on modern Ubuntu/Debian
-  apt: name=ntp state=absent
+  ansible.builtin.apt: name=ntp state=absent
   when: ansible_service_mgr == 'systemd'
 
 # vim: set ts=2 sw=2:

roles/common/tasks/packages_Debian.yml

@@ -2,11 +2,11 @@
 
 - block:
   - name: Configure apt mirror
-    template: src=sources.list.j2 dest=/etc/apt/sources.list owner=root group=root mode=0644
+    ansible.builtin.template: src=sources.list.j2 dest=/etc/apt/sources.list owner=root group=root mode=0644
     when: ansible_architecture != 'armv7l'
 
   - name: Set fact for base packages
-    set_fact:
+    ansible.builtin.set_fact:
       base_packages:
         - git
         - git-lfs
@@ -28,14 +28,14 @@
         - lsof
 
   - name: Install base packages
-    apt: name={{ base_packages }} state=present cache_valid_time=3600
+    ansible.builtin.apt: name={{ base_packages }} state=present cache_valid_time=3600
 
   - name: Configure cron-apt
-    import_tasks: cron-apt.yml
+    ansible.builtin.import_tasks: cron-apt.yml
     tags: cron-apt
 
   - name: Install tarsnap
-    import_tasks: tarsnap.yml
+    ansible.builtin.import_tasks: tarsnap.yml
   tags: packages
 
 # vim: set sw=2 ts=2:

roles/common/tasks/packages_Ubuntu.yml

@@ -2,14 +2,14 @@
 
 - block:
   - name: Configure apt mirror
-    template: src=sources.list.j2 dest=/etc/apt/sources.list owner=root group=root mode=0644
+    ansible.builtin.template: src=sources.list.j2 dest=/etc/apt/sources.list owner=root group=root mode=0644
     when: ansible_architecture != 'armv7l'
 
   - name: Upgrade base OS
-    apt: upgrade=dist cache_valid_time=3600
+    ansible.builtin.apt: upgrade=dist cache_valid_time=3600
 
   - name: Set Ubuntu base packages
-    set_fact:
+    ansible.builtin.set_fact:
       ubuntu_base_packages:
       - git
       - git-lfs
@@ -30,27 +30,27 @@
       - lsof
 
   - name: Install base packages
-    apt: pkg={{ ubuntu_base_packages }} state=present cache_valid_time=3600
+    ansible.builtin.apt: pkg={{ ubuntu_base_packages }} state=present cache_valid_time=3600
 
   # We have to remove snaps one by one in a specific order because some depend
   # on others. Only after that can we remove the corresponding system packages.
   - name: Remove lxd snap
-    snap: name=lxd state=absent
+    community.general.snap: name=lxd state=absent
     when: ansible_distribution_version is version('20.04', '==')
     ignore_errors: yes
 
   - name: Remove core18 snap
-    snap: name=core18 state=absent
+    community.general.snap: name=core18 state=absent
     when: ansible_distribution_version is version('20.04', '==')
     ignore_errors: yes
 
   - name: Remove snapd snap
-    snap: name=snapd state=absent
+    community.general.snap: name=snapd state=absent
     when: ansible_distribution_version is version('20.04', '==')
     ignore_errors: yes
 
   - name: Set fact for packages to remove (Ubuntu <= 18.04)
-    set_fact:
+    ansible.builtin.set_fact:
       ubuntu_annoying_packages:
         - whoopsie # security (CIS 4.1)
         - apport   # security (CIS 4.1)
@@ -66,7 +66,7 @@
     when: ansible_distribution_version is version('18.04', '<=')
 
   - name: Set fact for packages to remove (Ubuntu 20.04)
-    set_fact:
+    ansible.builtin.set_fact:
       ubuntu_annoying_packages:
         - whoopsie # security (CIS 4.1)
         - apport   # security (CIS 4.1)
@@ -78,10 +78,10 @@
     when: ansible_distribution_version is version('20.04', '==')
 
   - name: Remove packages
-    apt: name={{ ubuntu_annoying_packages }} state=absent purge=yes
+    ansible.builtin.apt: name={{ ubuntu_annoying_packages }} state=absent purge=yes
 
   - name: Disable annoying Canonical spam in MOTD
-    file: path={{ item }} mode=0644 state=absent
+    ansible.builtin.file: path={{ item }} mode=0644 state=absent
     loop:
       - /etc/update-motd.d/99-esm # Ubuntu 14.04
       - /etc/update-motd.d/10-help-text # Ubuntu 14.04+
@@ -91,18 +91,18 @@
     ignore_errors: yes
 
   - name: Disable annoying Canonical spam in MOTD
-    systemd: name={{ item }} state=stopped enabled=no
+    ansible.builtin.systemd: name={{ item }} state=stopped enabled=no
     when: ansible_service_mgr == 'systemd'
     loop:
       - motd-news.service
       - motd-news.timer
 
   - name: Configure cron-apt
-    import_tasks: cron-apt.yml
+    ansible.builtin.import_tasks: cron-apt.yml
     tags: cron-apt
 
   - name: Install tarsnap
-    import_tasks: tarsnap.yml
+    ansible.builtin.import_tasks: tarsnap.yml
   tags: packages
 
 # vim: set sw=2 ts=2:

roles/common/tasks/ssh-keys.yml

@@ -1,9 +1,9 @@
 ---
 - name: Zero .ssh/authorized_keys for provisioning user
-  file: dest={{ provisioning_user.home }}/.ssh/authorized_keys state=absent
+  ansible.builtin.file: dest={{ provisioning_user.home }}/.ssh/authorized_keys state=absent
 
 - name: Add public keys to authorized_keys
-  authorized_key: { user: '{{ provisioning_user.name }}', key: "{{ lookup('file',item) }}" }
+  ansible.posix.authorized_key: { user: '{{ provisioning_user.name }}', key: "{{ lookup('file',item) }}" }
   with_fileglob:
     # use descriptive names for keys, like: aorth-mzito-rsa.pub
     - ssh-pub-keys/*.pub

roles/common/tasks/sshd.yml

@@ -2,14 +2,14 @@
 
 # SSH configs don't change in Debian minor versions
 - name: Reconfigure /etc/ssh/sshd_config
-  template: src=sshd_config_{{ ansible_distribution }}-{{ ansible_distribution_major_version }}.j2 dest=/etc/ssh/sshd_config owner=root group=root mode=0600
+  ansible.builtin.template: src=sshd_config_{{ ansible_distribution }}-{{ ansible_distribution_major_version }}.j2 dest=/etc/ssh/sshd_config owner=root group=root mode=0600
   when: ansible_distribution == 'Debian'
   notify: reload sshd
 
 # Ubuntu is the only distro we have where SSH version is very different from 14.04 -> 14.10,
 # ie with new ciphers supported etc.
 - name: Reconfigure /etc/ssh/sshd_config
-  template: src=sshd_config_{{ ansible_distribution }}-{{ ansible_distribution_version }}.j2 dest=/etc/ssh/sshd_config owner=root group=root mode=0600
+  ansible.builtin.template: src=sshd_config_{{ ansible_distribution }}-{{ ansible_distribution_version }}.j2 dest=/etc/ssh/sshd_config owner=root group=root mode=0600
   when: ansible_distribution == 'Ubuntu'
   notify: reload sshd
 
@@ -40,7 +40,7 @@
       notify: reload sshd
 
 - name: Remove DSA and ECDSA host keys
-  file: name=/etc/ssh/{{ item }} state=absent
+  ansible.builtin.file: name=/etc/ssh/{{ item }} state=absent
   loop:
     - ssh_host_dsa_key
     - ssh_host_dsa_key.pub

roles/common/tasks/tarsnap.yml

@@ -1,24 +1,24 @@
 ---
 - name: Add Tarsnap apt mirror
-  template: src=tarsnap_sources.list.j2 dest=/etc/apt/sources.list.d/tarsnap.list owner=root group=root mode=0644
+  ansible.builtin.template: src=tarsnap_sources.list.j2 dest=/etc/apt/sources.list.d/tarsnap.list owner=root group=root mode=0644
   register: add_tarsnap_apt_repository
   when: ansible_architecture != 'armv7l'
 
 - name: Add GPG key for Tarsnap
-  apt_key: id=0xBF75EEAB040E447C url=https://pkg.tarsnap.com/tarsnap-deb-packaging-key.asc state=present
+  ansible.builtin.apt_key: id=0xBF75EEAB040E447C url=https://pkg.tarsnap.com/tarsnap-deb-packaging-key.asc state=present
   register: add_tarsnap_apt_key
 
 - name: Update apt cache
-  apt:
+  ansible.builtin.apt:
     update_cache: yes
   when:
     add_tarsnap_apt_key is changed or
     add_tarsnap_apt_repository is changed
 
 - name: Install tarsnap
-  apt: pkg=tarsnap cache_valid_time=3600
+  ansible.builtin.apt: pkg=tarsnap cache_valid_time=3600
 
 - name: Copy tarsnaprc
-  copy: src=tarsnaprc dest=/root/.tarsnaprc owner=root group=root mode=0600
+  ansible.builtin.copy: src=tarsnaprc dest=/root/.tarsnaprc owner=root group=root mode=0600
 
 # vim: set sw=2 ts=2: