roles/php-fpm: Use blocks to tag children of dynamic tasks

When using dynamic includes, child tasks do not inherit tags from their
parents. You must tag the parent and each child task separately, or use
a block to group children and then apply a tag to a block.

See: https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.5.html

roles/php-fpm/tasks/Ubuntu.yml

@@ -1,5 +1,7 @@
 ---
-- name: Install php7.0-fpm and deps
+
+- block:
+  - name: Install php7.0-fpm and deps
     apt: name={{ item }} state=present update_cache=yes
     loop:
       - php7.0-fpm
@@ -10,23 +12,21 @@
       # for Piwik
       - php7.0-mbstring
       - php7.0-xml
-  tags: php-fpm, packages
+    tags: packages
 
-# only copy php-fpm config for vhosts that need WordPress or PHP
-- name: Copy php-fpm pool config
+  # only copy php-fpm config for vhosts that need WordPress or PHP
+  - name: Copy php-fpm pool config
     template: src=php7.0-pool.conf.j2 dest=/etc/php/7.0/fpm/pool.d/{{ item.domain_name }}.conf owner=root group=root mode=0644
     loop: "{{ nginx_vhosts }}"
     when: (item.has_wordpress is defined and item.has_wordpress == True) or (item.needs_php is defined and item.needs_php == True)
     notify: reload php7.0-fpm
-  tags: php-fpm
 
-- name: Remove default www pool
+  - name: Remove default www pool
     file: path=/etc/php/7.0/fpm/pool.d/www.conf state=absent
     notify: reload php7.0-fpm
-  tags: php-fpm
 
-# re-configure php.ini
-- name: Update php.ini
+  # re-configure php.ini
+  - name: Update php.ini
     template: src=php7.0-php.ini.j2 dest=/etc/php/7.0/fpm/php.ini owner=root group=root mode=0644
     notify: reload php7.0-fpm
   tags: php-fpm

roles/php-fpm/tasks/Ubuntu_18.04.yml

@@ -1,5 +1,7 @@
 ---
-- name: Install php-fpm and deps
+
+- block:
+  - name: Install php-fpm and deps
     apt: name={{ item }} state=present update_cache=yes
     loop:
       - php-fpm
@@ -10,23 +12,21 @@
       # for Piwik
       - php-mbstring
       - php-xml
-  tags: php-fpm, packages
+    tags: packages
 
-# only copy php-fpm config for vhosts that need WordPress or PHP
-- name: Copy php-fpm pool config
+  # only copy php-fpm config for vhosts that need WordPress or PHP
+  - name: Copy php-fpm pool config
     template: src=php7.2-pool.conf.j2 dest=/etc/php/7.2/fpm/pool.d/{{ item.domain_name }}.conf owner=root group=root mode=0644
     loop: "{{ nginx_vhosts }}"
     when: (item.has_wordpress is defined and item.has_wordpress == True) or (item.needs_php is defined and item.needs_php == True)
     notify: reload php7.2-fpm
-  tags: php-fpm
 
-- name: Remove default www pool
+  - name: Remove default www pool
     file: path=/etc/php/7.2/fpm/pool.d/www.conf state=absent
     notify: reload php7.2-fpm
-  tags: php-fpm
 
-# re-configure php.ini
-- name: Update php.ini
+  # re-configure php.ini
+  - name: Update php.ini
     template: src=php7.2-php.ini.j2 dest=/etc/php/7.2/fpm/php.ini owner=root group=root mode=0644
     notify: reload php7.2-fpm
   tags: php-fpm