alanorth/hugo-theme-bootstrap4-blog
1
0
Fork 0
mirror of https://github.com/alanorth/hugo-theme-bootstrap4-blog.git synced 2024-12-21 01:52:19 +01:00
Code Releases Activity

layouts/_default/single.html: Adjust Disqus logic

Browse Source 
Bring the Disqus comments inside the <article> tag. The article has
a sizeable bottom margin seprating it from the blog footer, and if
Disqus comments are active they appear after this margin, and this
looks ugly.

Semantically, I think the comments should actually be inside the
article tag anyways (since they are directly related), as well as
further wrapped in article tags, but we don't control the code that
Disqus injects so we'll have to make do with this.

See: https://www.w3.org/TR/html5/sections.html#the-article-element
This commit is contained in:
Alan Orth 2017-01-07 11:22:45 +02:00
parent af39372a24
commit 1f6cc0cf42
Signed by: alanorth
GPG Key ID: 0FB860CC9C45B1B9
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
layouts/_default/single.html
View File

@ -19,14 +19,22 @@
{{ end }} {{ end }}
</ul> </ul>
{{ end }} {{ end }}
{{ if or (not .Site.Params.sharingicons.hide) (.Site.DisqusShortname) }}
<hr>
<footer>
{{ if not .Site.Params.sharingicons.hide }} {{ if not .Site.Params.sharingicons.hide }}
{{ partial "sharing-icons.html" . }} {{ partial "sharing-icons.html" . }}
{{ end }} {{ end }}
</article> <!-- /.blog-post -->
{{ if and (.Site.DisqusShortname) (ne .Params.comments false) }} {{ if and (.Site.DisqusShortname) (ne .Params.comments false) }}
{{ partial "disqus.html" . }} {{ partial "disqus.html" . }}
{{ end }} {{ end }}
</footer>
{{ end }}
</article> <!-- /.blog-post -->
{{ end }} {{ end }}