mirror of
https://github.com/ilri/dspace-statistics-api.git
synced 2024-12-26 14:34:31 +01:00
Alan Orth
d4518d62ad
I thought it was clever to only import these in the on_post handler because they aren't needed elsewhere, but it turns out that this is not a common pattern and even causes problems with testability. First, if the imports are at the top of the file as PEP8 recommends, then the WSGI server will import them once when it loads the app and they remain in memory for the lifecycle of the app. If the imports are in the on_post handler they would be re-imported on every request! Second, this pattern of importing in a method makes it tricky to use object patching in mocks. See: https://www.python.org/dev/peps/pep-0008/#imports |
||
---|---|---|
.. | ||
docs | ||
__init__.py | ||
app.py | ||
config.py | ||
database.py | ||
indexer.py | ||
items.py | ||
util.py |