CHANGELOG.md: Add note about ORDER BY

dspace_statistics_api/app.py: Use ORDER BY in /items
Since we are paging through the results by limit/offset we need to be sure that we are returning results deterministically.
2024-11-22 06:15:02 +01:00 · 2020-12-17 10:17:23 +02:00 · 2020-12-17 10:10:40 +02:00
2 changed files with 6 additions and 1 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

+## Unreleased
+### Changed
+- Add ORDER BY to /items resource to make sure results are returned
+deterministically
+
 ## [1.3.2] - 2020-11-18
 ### Fixed
 - Minor issue with limit parameter (> 0)
--- a/dspace_statistics_api/app.py
+++ b/dspace_statistics_api/app.py
@ -31,7 +31,7 @@ class AllItemsResource:

                # get statistics and use limit and offset to page through results
                cursor.execute(
-                    "SELECT id, views, downloads FROM items LIMIT %s OFFSET %s",
+                    "SELECT id, views, downloads FROM items ORDER BY id LIMIT %s OFFSET %s",
                    [limit, offset],
                )
Author	SHA1	Message	Date
Alan Orth	f3a0e3a671	CHANGELOG.md: Add note about ORDER BY All checks were successful continuous-integration/drone/push Build is passing Details	2020-12-17 10:17:23 +02:00
Alan Orth	4590fc8708	dspace_statistics_api/app.py: Use ORDER BY in /items Since we are paging through the results by limit/offset we need to be sure that we are returning results deterministically.	2020-12-17 10:10:40 +02:00