alanorth/dspace-statistics-api
1
0
Fork 0
mirror of https://github.com/ilri/dspace-statistics-api.git synced 2024-11-15 10:57:03 +01:00
Code Releases Activity
450 Commits 8 Branches 37 Tags 1.6 MiB
a9252d1771
Commit Graph

450 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Alan Orth
a835b0fdc5
Re-create pipenv environment from scratch 
When I originally created the pipenv environment I used the standard
pip requirements.txt that I already had, which captured all the mod-
ules and their exact versions at the time. This makes it hard to se-
parate the project's actual dependencies from the dependencies' dep-
endencies, complicating the Pipfile and making it hard to update mo-
dule versions later.

I've re-created the environment with the following commands:

    $ pipenv install gunicorn falcon psycopg2-binary git+https://github.com/alanorth/SolrClient.git@kazoo-2.5.0#egg=SolrClient
    $ pipenv install --dev ipython flake8 pytest
 2018-11-14 09:07:32 +02:00
Alan Orth
a88600c92b
README.md: Add note about GPLv3 2018-11-13 12:34:31 +02:00
Alan Orth
019d9242c9
Merge pull request #7 from ilri/use-pip 
Rework to use pip instead of pipenv
 2018-11-12 09:17:16 +02:00
Alan Orth
f4d7312a3f
CHANGELOG.md: Add unreleased changes 2018-11-12 09:02:04 +02:00
Alan Orth
9c46cfc7e2
Use Python 3.7 for pipenv 
Now that I'm only using pipenv locally it shouldn't create problems
for people. They can still just create a vanilla virtualenv and use
pip to install the dependencies.
 2018-11-12 08:54:54 +02:00
Alan Orth
c1c2e319ac
README.md: Rework to use pip instead of pipenv 
Pipenv is great for local development, but I don't think many people
are using it yet. I can use it locally and on Travis, but still keep
vanilla requirements.txt for use with pip. The requirements.txt file
can be generated easily from pipenv itself:

    $ pipenv lock -r > requirements.txt

The same for the development requirements:

    $ pipenv lock -r -d > requirements-dev.txt
 2018-11-12 08:49:02 +02:00
Alan Orth
0895b4f469
Add requirements-dev.txt for pip 
Generated with pipenv lock -r -d. Will be used for separating the
development dependencies.
 2018-11-12 08:48:45 +02:00
Alan Orth
dcfef06a65
Pipfile.lock: Run pipenv update 2018-11-12 08:20:47 +02:00
Alan Orth
13736d6359
CHANGELOG.md: Move unreleased changes to verison 0.8.0 2018-11-11 17:16:26 +02:00
Alan Orth
4fc64edeb8
Merge pull request #6 from ilri/pytest 
Pytest
 2018-11-11 17:14:49 +02:00
Alan Orth
2a8901dc4f
CHANGELOG.md: Update notes 2018-11-11 17:10:45 +02:00
Alan Orth
e25c974796
README.md: We have tests now 2018-11-11 17:08:51 +02:00
Alan Orth
ffc62e9ee6
tests/test_api.py: Use response.text for all json.loads() 
This allows the code to work in Python 3.5 as well as 3.6+.
 2018-11-11 17:05:31 +02:00
Alan Orth
556c5ae088
tests/test_api.py: Use response.text instead of content 
Falcon's response content is raw bytes, while its text is a string.
Let's use the latter so we can use json.loads() in Python 3.5, 3.6,
and 3.7 with the same code.

See: https://falcon.readthedocs.io/en/stable/api/testing.html
 2018-11-11 17:01:17 +02:00
Alan Orth
d94134f80a
tests/test_api.py: Try to add workaround for Python 3.5 
In Python 3.5 it seems that json.loads() cannot decode a bytes, but
it works in Python 3.6 and 3.7. Let's try a workaround to see if we
can get it working on both Python 3.5 and 3.6+.

See: https://docs.python.org/3.5/library/json.html#json.loads
See: https://docs.python.org/3.6/library/json.html#json.loads
 2018-11-11 17:00:20 +02:00
Alan Orth
586231eb2d
.travis.yml: Use PostgreSQL 9.5 
Default PostgreSQL in Travis CI is 9.2 which is very old, so let's
try to use 9.5.

See: https://docs.travis-ci.com/user/database-setup/#postgresql
 2018-11-11 16:41:35 +02:00
Alan Orth
766b77a3b6
.travis.yml: Use PostgreSQL directly 
It seems that Travis CI already has a PostgreSQL service running.
 2018-11-11 16:35:28 +02:00
Alan Orth
1959e8154e
.travis.yml: Use localhost for Docker's PostgreSQL ports 
See: https://docs.travis-ci.com/user/docker/
 2018-11-11 16:28:18 +02:00
Alan Orth
d40b2f0b2e Test API using pytest and PostgreSQL on Travis 
First attempt at getting the Travis Docker setup correct. Inspired
by the Travis pipenv setup used in Responder.

See: https://docs.travis-ci.com/user/docker/
See: https://github.com/kennethreitz/responder/blob/master/.travis.yml
 2018-11-11 16:25:16 +02:00
Alan Orth
061d0a8f5f CHANGELOG.md: Add API tests to unreleased changes 2018-11-11 16:24:54 +02:00
Alan Orth
e57660ff88 Add initial pytest configuration 
From: https://github.com/kennethreitz/responder/blob/master/pytest.ini
 2018-11-11 16:24:54 +02:00
Alan Orth
5c8756bede Add pytest to pipenv development packages 2018-11-11 16:24:54 +02:00
Alan Orth
bae9fb80e4 Add initial API tests 
Test the basic assumptions of the API like response codes and types.
 2018-11-11 16:24:54 +02:00
Alan Orth
8a65d99e08
.travis.yml: Don't limit builds to master 
This is good in theory but it means we can't trigger builds for other
branches on the fly from the Travis web interface.
 2018-11-11 16:21:48 +02:00
Alan Orth
d479b7dc6c
CHANGELOG.md: Syntax fixes 2018-11-11 00:08:44 +02:00
Alan Orth
40aac8bf89
Merge pull request #5 from ilri/database-error-handling 
Database error handling
 2018-11-11 00:07:25 +02:00
Alan Orth
53ba6f2936
CHANGELOG.md: Add database try/except to unreleased changes 2018-11-11 00:05:49 +02:00
Alan Orth
140cc4cb07
README.md: Remove TODO for database try/except 
Now database connection errors are properly excepted and raised.
 2018-11-11 00:04:28 +02:00
Alan Orth
d5d2d2149b
dspace_statistics_api/database.py: Raise HTTP 500 on error 
Properly except on database connection error and raise an HTTP 500
instead of spamming the console/log with twenty lines of text.
 2018-11-10 23:58:58 +02:00
Alan Orth
4c51d12eb4
CHANGELOG.md: Move unreleased changes to version 0.7.0 2018-11-07 17:55:01 +02:00
Alan Orth
a6ce44e852
Merge pull request #4 from ilri/database-refactor 
Database refactor
 2018-11-07 17:54:04 +02:00
Alan Orth
f6e866a589
dspace_statistics_api/indexer.py: Remove debug code 2018-11-07 17:51:24 +02:00
Alan Orth
eb5c187d41
CHANGELOG.md: Add note about database re-factor 2018-11-07 17:50:46 +02:00
Alan Orth
b06c82bb16
README.md: Remove TODO about closing database connection 
Now I'm using a database manager class with Python's "with" context
blocks to automatically and concisely open and close connections.
 2018-11-07 17:47:59 +02:00
Alan Orth
2f342be948
Refactor database code to use a context manager 
Instead of opening one global persistent database connection when
the application I am now abstracting it to a class that I can use
in combination with Python's "with" context. Both connections and
cursors are kept for the context of each "with" block and closed
automatically when exiting.

See: https://alysivji.github.io/managing-resources-with-context-managers-pythonic.html
See: http://initd.org/psycopg/docs/connection.html#connection.close
 2018-11-07 17:41:21 +02:00
Alan Orth
e39f2b260c
Merge pull request #3 from ilri/ipython 
Add ipython to pipenv dev packages
 2018-11-07 17:09:09 +02:00
Alan Orth
60ad474b88
Add ipython to pipenv dev packages 
This is very useful for debugging Python code interactively.
 2018-11-07 17:07:14 +02:00
Alan Orth
888f85d19e
README.md: Adjust installation for pipenv 
It's nicer to manager module versions using pipenv, and I can still
generate a requirements.txt for deploying the exact versions on the
production server.
 2018-11-04 16:07:27 +02:00
Alan Orth
df7de93964
CHANGELOG.md: Add pipenv to unreleased changes 2018-11-04 15:59:11 +02:00
Alan Orth
7218631cc4
requirements.txt: Regenerate 
Created from pipenv with the following command:

    $ pipenv lock -r > requirements.txt
 2018-11-04 15:58:31 +02:00
Alan Orth
085e525b2f
Regenerate pipenv 
Uses 'kazoo-2.5.0' branch name for installing SolrClient instead of
the commit hash and adds flake8 as a dev package. This means that I
can track dependencies for production and development and still end
up with a requirements.txt for produciton.
 2018-11-04 15:55:28 +02:00
Alan Orth
e1580df12f
requirements.txt: Update packages 
Generated from pipenv with:

    $ pipenv run pip freeze > requirements.txt
 2018-11-04 15:39:09 +02:00
Alan Orth
be18779ff9
Add flake8 to pipenv 2018-11-04 15:38:51 +02:00
Alan Orth
60cfd8f23b
Add Pipfile for pipenv 
Eventually I'd like to be able to use pipenv instead of plain pip.
For now I'll just keep using pipenv and generating requirements.txt
like this:

    $ pipenv run pip freeze > requirements.txt

Then I can kinda have the best of both worlds, where I use pipenv
on my local machine and pip with requirements.txt on the server.
 2018-11-04 15:35:47 +02:00
Alan Orth
87fd117d77
.hound.yml: Set pull requests to failed if build fails 2018-11-04 00:53:37 +02:00
Alan Orth
f262ebdca2
CHANGELOG.md: Add unreleased changes 2018-11-04 00:50:46 +02:00
Alan Orth
64d7f1a3b2
Enable Flake8 validation in Hound CI 
Will check all pull requests in the project to make sure they don't
violate PEP 8 style (except the E501 for long lines because I think
it makes code hard to read).
 2018-11-04 00:48:06 +02:00
Alan Orth
a238a727d2
CHANGELOG.md: Add unreleased changes 2018-11-04 00:05:16 +02:00
Alan Orth
cc5ce3ab98 Correct issues highlighted by Flake8 
Flake8 validates code style against PEP 8 in order to encourage the
writing of idiomatic Python. For reference, I am currently ignoring
errors about line length (E501) because I feel it makes code harder
to read.

This is the invocation I am using:

    $ flake8 --ignore E501 dspace_statistics_api
 2018-11-04 00:04:27 +02:00
Alan Orth
70dfcb93c5
dspace_statistics_api/database.py: Don't quote host in connect() 2018-11-03 22:43:05 +02:00