239 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Alan Orth	e25c974796	README.md: We have tests now	2018-11-11 17:08:51 +02:00
Alan Orth	ffc62e9ee6	tests/test_api.py: Use response.text for all json.loads() ... This allows the code to work in Python 3.5 as well as 3.6+.	2018-11-11 17:05:31 +02:00
Alan Orth	556c5ae088	tests/test_api.py: Use response.text instead of content ... Falcon's response content is raw bytes, while its text is a string. Let's use the latter so we can use json.loads() in Python 3.5, 3.6, and 3.7 with the same code. See: https://falcon.readthedocs.io/en/stable/api/testing.html	2018-11-11 17:01:17 +02:00
Alan Orth	d94134f80a	tests/test_api.py: Try to add workaround for Python 3.5 ... In Python 3.5 it seems that json.loads() cannot decode a bytes, but it works in Python 3.6 and 3.7. Let's try a workaround to see if we can get it working on both Python 3.5 and 3.6+. See: https://docs.python.org/3.5/library/json.html#json.loads See: https://docs.python.org/3.6/library/json.html#json.loads	2018-11-11 17:00:20 +02:00
Alan Orth	586231eb2d	.travis.yml: Use PostgreSQL 9.5 ... Default PostgreSQL in Travis CI is 9.2 which is very old, so let's try to use 9.5. See: https://docs.travis-ci.com/user/database-setup/#postgresql	2018-11-11 16:41:35 +02:00
Alan Orth	766b77a3b6	.travis.yml: Use PostgreSQL directly ... It seems that Travis CI already has a PostgreSQL service running.	2018-11-11 16:35:28 +02:00
Alan Orth	1959e8154e	.travis.yml: Use localhost for Docker's PostgreSQL ports ... See: https://docs.travis-ci.com/user/docker/	2018-11-11 16:28:18 +02:00
Alan Orth	d40b2f0b2e	Test API using pytest and PostgreSQL on Travis ... First attempt at getting the Travis Docker setup correct. Inspired by the Travis pipenv setup used in Responder. See: https://docs.travis-ci.com/user/docker/ See: https://github.com/kennethreitz/responder/blob/master/.travis.yml	2018-11-11 16:25:16 +02:00
Alan Orth	061d0a8f5f	CHANGELOG.md: Add API tests to unreleased changes	2018-11-11 16:24:54 +02:00
Alan Orth	e57660ff88	Add initial pytest configuration ... From: https://github.com/kennethreitz/responder/blob/master/pytest.ini	2018-11-11 16:24:54 +02:00
Alan Orth	5c8756bede	Add pytest to pipenv development packages	2018-11-11 16:24:54 +02:00
Alan Orth	bae9fb80e4	Add initial API tests ... Test the basic assumptions of the API like response codes and types.	2018-11-11 16:24:54 +02:00
Alan Orth	8a65d99e08	.travis.yml: Don't limit builds to master ... This is good in theory but it means we can't trigger builds for other branches on the fly from the Travis web interface.	2018-11-11 16:21:48 +02:00
Alan Orth	d479b7dc6c	CHANGELOG.md: Syntax fixes	2018-11-11 00:08:44 +02:00
Alan Orth	40aac8bf89	Merge pull request #5 from ilri/database-error-handling ... Database error handling	2018-11-11 00:07:25 +02:00
Alan Orth	53ba6f2936	CHANGELOG.md: Add database try/except to unreleased changes	2018-11-11 00:05:49 +02:00
Alan Orth	140cc4cb07	README.md: Remove TODO for database try/except ... Now database connection errors are properly excepted and raised.	2018-11-11 00:04:28 +02:00
Alan Orth	d5d2d2149b	dspace_statistics_api/database.py: Raise HTTP 500 on error ... Properly except on database connection error and raise an HTTP 500 instead of spamming the console/log with twenty lines of text.	2018-11-10 23:58:58 +02:00
Alan Orth	4c51d12eb4	CHANGELOG.md: Move unreleased changes to version 0.7.0	2018-11-07 17:55:01 +02:00
Alan Orth	a6ce44e852	Merge pull request #4 from ilri/database-refactor ... Database refactor	2018-11-07 17:54:04 +02:00
Alan Orth	f6e866a589	dspace_statistics_api/indexer.py: Remove debug code	2018-11-07 17:51:24 +02:00
Alan Orth	eb5c187d41	CHANGELOG.md: Add note about database re-factor	2018-11-07 17:50:46 +02:00
Alan Orth	b06c82bb16	README.md: Remove TODO about closing database connection ... Now I'm using a database manager class with Python's "with" context blocks to automatically and concisely open and close connections.	2018-11-07 17:47:59 +02:00
Alan Orth	2f342be948	Refactor database code to use a context manager ... Instead of opening one global persistent database connection when the application I am now abstracting it to a class that I can use in combination with Python's "with" context. Both connections and cursors are kept for the context of each "with" block and closed automatically when exiting. See: https://alysivji.github.io/managing-resources-with-context-managers-pythonic.html See: http://initd.org/psycopg/docs/connection.html#connection.close	2018-11-07 17:41:21 +02:00
Alan Orth	e39f2b260c	Merge pull request #3 from ilri/ipython ... Add ipython to pipenv dev packages	2018-11-07 17:09:09 +02:00
Alan Orth	60ad474b88	Add ipython to pipenv dev packages ... This is very useful for debugging Python code interactively.	2018-11-07 17:07:14 +02:00
Alan Orth	888f85d19e	README.md: Adjust installation for pipenv ... It's nicer to manager module versions using pipenv, and I can still generate a requirements.txt for deploying the exact versions on the production server.	2018-11-04 16:07:27 +02:00
Alan Orth	df7de93964	CHANGELOG.md: Add pipenv to unreleased changes	2018-11-04 15:59:11 +02:00
Alan Orth	7218631cc4	requirements.txt: Regenerate ... Created from pipenv with the following command: $ pipenv lock -r > requirements.txt	2018-11-04 15:58:31 +02:00
Alan Orth	085e525b2f	Regenerate pipenv ... Uses 'kazoo-2.5.0' branch name for installing SolrClient instead of the commit hash and adds flake8 as a dev package. This means that I can track dependencies for production and development and still end up with a requirements.txt for produciton.	2018-11-04 15:55:28 +02:00
Alan Orth	e1580df12f	requirements.txt: Update packages ... Generated from pipenv with: $ pipenv run pip freeze > requirements.txt	2018-11-04 15:39:09 +02:00
Alan Orth	be18779ff9	Add flake8 to pipenv	2018-11-04 15:38:51 +02:00
Alan Orth	60cfd8f23b	Add Pipfile for pipenv ... Eventually I'd like to be able to use pipenv instead of plain pip. For now I'll just keep using pipenv and generating requirements.txt like this: $ pipenv run pip freeze > requirements.txt Then I can kinda have the best of both worlds, where I use pipenv on my local machine and pip with requirements.txt on the server.	2018-11-04 15:35:47 +02:00
Alan Orth	87fd117d77	.hound.yml: Set pull requests to failed if build fails	2018-11-04 00:53:37 +02:00
Alan Orth	f262ebdca2	CHANGELOG.md: Add unreleased changes	2018-11-04 00:50:46 +02:00
Alan Orth	64d7f1a3b2	Enable Flake8 validation in Hound CI ... Will check all pull requests in the project to make sure they don't violate PEP 8 style (except the E501 for long lines because I think it makes code hard to read).	2018-11-04 00:48:06 +02:00
Alan Orth	a238a727d2	CHANGELOG.md: Add unreleased changes	2018-11-04 00:05:16 +02:00
Alan Orth	cc5ce3ab98	Correct issues highlighted by Flake8 ... Flake8 validates code style against PEP 8 in order to encourage the writing of idiomatic Python. For reference, I am currently ignoring errors about line length (E501) because I feel it makes code harder to read. This is the invocation I am using: $ flake8 --ignore E501 dspace_statistics_api	2018-11-04 00:04:27 +02:00
Alan Orth	70dfcb93c5	dspace_statistics_api/database.py: Don't quote host in connect()	2018-11-03 22:43:05 +02:00
Alan Orth	69bcd1b5e4	CHANGELOG.md: Add unreleased changes	2018-11-03 22:42:08 +02:00
Alan Orth	5f3bd61998	Allow configuration of PostgreSQL port ... Defaults to port 5432, but can be overridden with DATABASE_PORT.	2018-11-03 22:40:45 +02:00
Alan Orth	e54dd8888f	README.md: Update requirements	2018-11-01 16:31:36 +02:00
Alan Orth	2ba09f8693	README.md: Improve introduction ... Obsessed with the text presentation and line length in GitHub!	2018-11-01 16:28:01 +02:00
Alan Orth	a468a87a5a	README.md: Improve introduction	2018-11-01 15:58:12 +02:00
Alan Orth	6a30b6550d	README.md: Improve introduction	2018-11-01 15:45:53 +02:00
Alan Orth	18f013bfa0	README.md: Add Falcon to introduction	2018-11-01 10:24:37 +02:00
Alan Orth	78900b5d85	CHANGELOG.md: Add changes for v0.6.1	2018-11-01 00:39:12 +02:00
Alan Orth	eb08832bf8	Sync API documentation HTML with README.md	2018-11-01 00:37:52 +02:00
Alan Orth	c2ec780ad9	README.md: Improve API documentation	2018-11-01 00:37:40 +02:00
Alan Orth	df8ebc8bf1	README.md: Improve API endpoint documentation	2018-11-01 00:31:16 +02:00