Alan Orth
0650c5985e
Add SPDX short license identifier to all Python files
...
continuous-integration/drone/push Build is passing
Details
See: https://spdx.github.io/spdx-spec/appendix-V-using-SPDX-short-identifiers-in-source-files/
2021-03-22 13:42:42 +02:00
Alan Orth
0ef071a91d
dspace_statistics_api: Use f-strings instead of format()
...
We had previously been avoiding the f-strings because we needed to
run on Python 3.5 and they were only available in Python 3.6+, but
now the black formatter requires Python 3.6 and all our systems are
running Python 3.6+ anyways.
2020-03-02 11:24:29 +02:00
Alan Orth
cb3c3d37fa
Sort imports with isort
2019-11-27 12:31:04 +02:00
Alan Orth
4ff1fd4a22
Format code with black
2019-11-27 12:30:06 +02:00
Alan Orth
d5d2d2149b
dspace_statistics_api/database.py: Raise HTTP 500 on error
...
Properly except on database connection error and raise an HTTP 500
instead of spamming the console/log with twenty lines of text.
2018-11-10 23:58:58 +02:00
Alan Orth
2f342be948
Refactor database code to use a context manager
...
Instead of opening one global persistent database connection when
the application I am now abstracting it to a class that I can use
in combination with Python's "with" context. Both connections and
cursors are kept for the context of each "with" block and closed
automatically when exiting.
See: https://alysivji.github.io/managing-resources-with-context-managers-pythonic.html
See: http://initd.org/psycopg/docs/connection.html#connection.close
2018-11-07 17:41:21 +02:00
Alan Orth
cc5ce3ab98
Correct issues highlighted by Flake8
...
Flake8 validates code style against PEP 8 in order to encourage the
writing of idiomatic Python. For reference, I am currently ignoring
errors about line length (E501) because I feel it makes code harder
to read.
This is the invocation I am using:
$ flake8 --ignore E501 dspace_statistics_api
2018-11-04 00:04:27 +02:00
Alan Orth
70dfcb93c5
dspace_statistics_api/database.py: Don't quote host in connect()
2018-11-03 22:43:05 +02:00
Alan Orth
5f3bd61998
Allow configuration of PostgreSQL port
...
Defaults to port 5432, but can be overridden with DATABASE_PORT.
2018-11-03 22:40:45 +02:00
Alan Orth
c027f01b48
Refactor project structure
...
This follows guidance from several well-known Python best practices
guides. Basically, the idea is create a package for the application
that is comprised of several re-usable modules.
See: https://docs.python-guide.org/writing/structure/
See: https://realpython.com/python-application-layouts/
2018-10-28 11:14:21 +02:00
Alan Orth