alanorth/csv-metadata-quality
1
0
Fork 0
mirror of https://github.com/ilri/csv-metadata-quality.git synced 2024-11-24 23:00:17 +01:00
Code Releases Activity

csv_metadata_quality/fix.py: fix bug in regions

Browse Source 
We need to make sure we're only manipulating the regions if we have
any missing. The previous code was always manipulating the existing
row, even when there were no missing regions, which resulted in new
values like "Eastern Africa||".
This commit is contained in:
Alan Orth 2022-09-01 16:15:32 +03:00
parent 7ce20726d0
commit f49214fa2e
Signed by: alanorth
GPG Key ID: 0FB860CC9C45B1B9
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
csv_metadata_quality/fix.py
View File

@ -369,14 +369,15 @@ def countries_match_regions(row):
) )
missing_regions.append(un_region) missing_regions.append(un_region)
# Add the missing regions back to the row, paying attention to whether if len(missing_regions) > 0:
# or not the row's region column is None (aka null) or just an empty # Add the missing regions back to the row, paying attention to whether
# string (length would be 0). # or not the row's region column is None (aka null) or just an empty
if row[region_column_name] is not None and len(row[region_column_name]) > 0: # string (length would be 0).
row[region_column_name] = ( if row[region_column_name] is not None and len(row[region_column_name]) > 0:
row[region_column_name] + "||" + "||".join(missing_regions) row[region_column_name] = (
) row[region_column_name] + "||" + "||".join(missing_regions)
else: )
row[region_column_name] = "||".join(missing_regions) else:
row[region_column_name] = "||".join(missing_regions)
return row return row