From 5fcaa63bd5057ba2ed0336b3ad1750681a4e118c Mon Sep 17 00:00:00 2001 From: Alan Orth Date: Mon, 6 Jul 2020 13:41:51 +0300 Subject: [PATCH] csv_metadata_quality/check.py: Prune requests cache once We only need to prune the requests cache once before using it, not for every value we check. --- csv_metadata_quality/check.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/csv_metadata_quality/check.py b/csv_metadata_quality/check.py index bafb2c7..f160461 100755 --- a/csv_metadata_quality/check.py +++ b/csv_metadata_quality/check.py @@ -221,23 +221,23 @@ def agrovoc(field, field_name): if pd.isna(field): return + # enable transparent request cache with thirty days expiry + expire_after = timedelta(days=30) + requests_cache.install_cache( + "agrovoc-response-cache", expire_after=expire_after + ) + + # prune old cache entries + requests_cache.core.remove_expired_responses() + # Try to split multi-value field on "||" separator for value in field.split("||"): request_url = ( f"http://agrovoc.uniroma2.it/agrovoc/rest/v1/agrovoc/search?query={value}" ) - # enable transparent request cache with thirty days expiry - expire_after = timedelta(days=30) - requests_cache.install_cache( - "agrovoc-response-cache", expire_after=expire_after - ) - request = requests.get(request_url) - # prune old cache entries - requests_cache.core.remove_expired_responses() - if request.status_code == requests.codes.ok: data = request.json()