alanorth/csv-metadata-quality
1
0
Fork 0
mirror of https://github.com/ilri/csv-metadata-quality.git synced 2024-11-23 22:30:20 +01:00
Code Releases Activity

tests: apply fixes from fixit
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source 
RewriteToLiteral: It's slower to call list() than using the empty literal
This commit is contained in:
Alan Orth 2023-12-09 12:20:35 +03:00
parent 940a325d61
commit 2cc2dbe952
Signed by: alanorth
GPG Key ID: 0FB860CC9C45B1B9
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tests/test_check.py
View File

@ -257,7 +257,7 @@ def test_check_incorrect_iso_639_1_language(capsys):
title = "A randomised vaccine field trial in Kenya demonstrates protection against wildebeest-associated malignant catarrhal fever in cattle" title = "A randomised vaccine field trial in Kenya demonstrates protection against wildebeest-associated malignant catarrhal fever in cattle"
language = "es" language = "es"
exclude = list() exclude = []
# Create a dictionary to mimic Pandas series # Create a dictionary to mimic Pandas series
row = {"dc.title": title, "dc.language.iso": language} row = {"dc.title": title, "dc.language.iso": language}
@ -277,7 +277,7 @@ def test_check_incorrect_iso_639_3_language(capsys):
title = "A randomised vaccine field trial in Kenya demonstrates protection against wildebeest-associated malignant catarrhal fever in cattle" title = "A randomised vaccine field trial in Kenya demonstrates protection against wildebeest-associated malignant catarrhal fever in cattle"
language = "spa" language = "spa"
exclude = list() exclude = []
# Create a dictionary to mimic Pandas series # Create a dictionary to mimic Pandas series
row = {"dc.title": title, "dc.language.iso": language} row = {"dc.title": title, "dc.language.iso": language}
@ -297,7 +297,7 @@ def test_check_correct_iso_639_1_language():
title = "A randomised vaccine field trial in Kenya demonstrates protection against wildebeest-associated malignant catarrhal fever in cattle" title = "A randomised vaccine field trial in Kenya demonstrates protection against wildebeest-associated malignant catarrhal fever in cattle"
language = "en" language = "en"
exclude = list() exclude = []
# Create a dictionary to mimic Pandas series # Create a dictionary to mimic Pandas series
row = {"dc.title": title, "dc.language.iso": language} row = {"dc.title": title, "dc.language.iso": language}
@ -313,7 +313,7 @@ def test_check_correct_iso_639_3_language():
title = "A randomised vaccine field trial in Kenya demonstrates protection against wildebeest-associated malignant catarrhal fever in cattle" title = "A randomised vaccine field trial in Kenya demonstrates protection against wildebeest-associated malignant catarrhal fever in cattle"
language = "eng" language = "eng"
exclude = list() exclude = []
# Create a dictionary to mimic Pandas series # Create a dictionary to mimic Pandas series
row = {"dc.title": title, "dc.language.iso": language} row = {"dc.title": title, "dc.language.iso": language}
@ -407,7 +407,7 @@ def test_check_doi_field():
# the citation and a DOI field. # the citation and a DOI field.
d = {"cg.identifier.doi": doi, "dcterms.bibliographicCitation": citation} d = {"cg.identifier.doi": doi, "dcterms.bibliographicCitation": citation}
series = pd.Series(data=d) series = pd.Series(data=d)
exclude = list() exclude = []
result = check.citation_doi(series, exclude) result = check.citation_doi(series, exclude)
@ -418,7 +418,7 @@ def test_check_doi_only_in_citation(capsys):
"""Test an item with a DOI in its citation, but no DOI field.""" """Test an item with a DOI in its citation, but no DOI field."""
citation = "Orth, A. 2021. Testing all the things. doi: 10.1186/1743-422X-9-218" citation = "Orth, A. 2021. Testing all the things. doi: 10.1186/1743-422X-9-218"
exclude = list() exclude = []
# Emulate a column in a transposed dataframe (which is just a series), with # Emulate a column in a transposed dataframe (which is just a series), with
# an empty DOI field and a citation containing a DOI. # an empty DOI field and a citation containing a DOI.
@ -439,7 +439,7 @@ def test_title_in_citation():
title = "Testing all the things" title = "Testing all the things"
citation = "Orth, A. 2021. Testing all the things." citation = "Orth, A. 2021. Testing all the things."
exclude = list() exclude = []
# Emulate a column in a transposed dataframe (which is just a series), with # Emulate a column in a transposed dataframe (which is just a series), with
# the title and citation. # the title and citation.
@ -456,7 +456,7 @@ def test_title_not_in_citation(capsys):
title = "Testing all the things" title = "Testing all the things"
citation = "Orth, A. 2021. Testing all teh things." citation = "Orth, A. 2021. Testing all teh things."
exclude = list() exclude = []
# Emulate a column in a transposed dataframe (which is just a series), with # Emulate a column in a transposed dataframe (which is just a series), with
# the title and citation. # the title and citation.
@ -477,7 +477,7 @@ def test_country_matches_region():
country = "Kenya" country = "Kenya"
region = "Eastern Africa" region = "Eastern Africa"
exclude = list() exclude = []
# Emulate a column in a transposed dataframe (which is just a series) # Emulate a column in a transposed dataframe (which is just a series)
d = {"cg.coverage.country": country, "cg.coverage.region": region} d = {"cg.coverage.country": country, "cg.coverage.region": region}
@ -495,7 +495,7 @@ def test_country_not_matching_region(capsys):
country = "Kenya" country = "Kenya"
region = "" region = ""
missing_region = "Eastern Africa" missing_region = "Eastern Africa"
exclude = list() exclude = []
# Emulate a column in a transposed dataframe (which is just a series) # Emulate a column in a transposed dataframe (which is just a series)
d = { d = {

2
tests/test_fix.py
View File

@ -131,7 +131,7 @@ def test_fix_country_not_matching_region():
country = "Kenya" country = "Kenya"
region = "" region = ""
missing_region = "Eastern Africa" missing_region = "Eastern Africa"
exclude = list() exclude = []
# Emulate a column in a transposed dataframe (which is just a series) # Emulate a column in a transposed dataframe (which is just a series)
d = { d = {