2021-03-14 08:07:35 +01:00
|
|
|
|
import os
|
2021-03-11 09:52:20 +01:00
|
|
|
|
import re
|
2020-10-06 16:11:39 +02:00
|
|
|
|
from datetime import datetime, timedelta
|
|
|
|
|
|
2019-07-26 22:14:10 +02:00
|
|
|
|
import pandas as pd
|
2020-10-06 16:11:39 +02:00
|
|
|
|
import requests
|
|
|
|
|
import requests_cache
|
2021-03-11 09:33:16 +01:00
|
|
|
|
import spdx_license_list
|
2021-02-21 12:01:25 +01:00
|
|
|
|
from colorama import Fore
|
2020-10-06 16:11:39 +02:00
|
|
|
|
from pycountry import languages
|
2021-03-11 09:52:20 +01:00
|
|
|
|
from stdnum import isbn as stdnum_isbn
|
|
|
|
|
from stdnum import issn as stdnum_issn
|
2019-07-26 22:14:10 +02:00
|
|
|
|
|
2019-07-28 16:47:28 +02:00
|
|
|
|
|
2019-07-26 22:14:10 +02:00
|
|
|
|
def issn(field):
|
|
|
|
|
"""Check if an ISSN is valid.
|
|
|
|
|
|
|
|
|
|
Prints the ISSN if invalid.
|
|
|
|
|
|
|
|
|
|
stdnum's is_valid() function never raises an exception.
|
|
|
|
|
|
|
|
|
|
See: https://arthurdejong.org/python-stdnum/doc/1.11/index.html#stdnum.module.is_valid
|
|
|
|
|
"""
|
|
|
|
|
|
|
|
|
|
# Skip fields with missing values
|
|
|
|
|
if pd.isna(field):
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
# Try to split multi-value field on "||" separator
|
2019-08-29 00:10:39 +02:00
|
|
|
|
for value in field.split("||"):
|
2019-07-26 22:14:10 +02:00
|
|
|
|
|
2021-03-11 09:52:20 +01:00
|
|
|
|
if not stdnum_issn.is_valid(value):
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(f"{Fore.RED}Invalid ISSN: {Fore.RESET}{value}")
|
2019-07-26 22:14:10 +02:00
|
|
|
|
|
2019-07-27 00:28:08 +02:00
|
|
|
|
return field
|
|
|
|
|
|
2019-07-26 22:14:10 +02:00
|
|
|
|
|
|
|
|
|
def isbn(field):
|
|
|
|
|
"""Check if an ISBN is valid.
|
|
|
|
|
|
|
|
|
|
Prints the ISBN if invalid.
|
|
|
|
|
|
|
|
|
|
stdnum's is_valid() function never raises an exception.
|
|
|
|
|
|
|
|
|
|
See: https://arthurdejong.org/python-stdnum/doc/1.11/index.html#stdnum.module.is_valid
|
|
|
|
|
"""
|
|
|
|
|
|
2019-07-26 22:44:58 +02:00
|
|
|
|
# Skip fields with missing values
|
|
|
|
|
if pd.isna(field):
|
|
|
|
|
return
|
|
|
|
|
|
2019-07-26 22:14:10 +02:00
|
|
|
|
# Try to split multi-value field on "||" separator
|
2019-08-29 00:10:39 +02:00
|
|
|
|
for value in field.split("||"):
|
2019-07-26 22:14:10 +02:00
|
|
|
|
|
2021-03-11 09:52:20 +01:00
|
|
|
|
if not stdnum_isbn.is_valid(value):
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(f"{Fore.RED}Invalid ISBN: {Fore.RESET}{value}")
|
2019-07-26 22:48:24 +02:00
|
|
|
|
|
2019-07-27 00:28:08 +02:00
|
|
|
|
return field
|
|
|
|
|
|
2019-07-26 22:48:24 +02:00
|
|
|
|
|
2020-01-16 11:35:11 +01:00
|
|
|
|
def separators(field, field_name):
|
2021-01-03 14:30:03 +01:00
|
|
|
|
"""Check for invalid and unnecessary multi-value separators, for example:
|
|
|
|
|
|
|
|
|
|
value|value
|
|
|
|
|
value|||value
|
|
|
|
|
value||value||
|
2019-07-26 22:48:24 +02:00
|
|
|
|
|
|
|
|
|
Prints the field with the invalid multi-value separator.
|
|
|
|
|
"""
|
|
|
|
|
|
|
|
|
|
# Skip fields with missing values
|
|
|
|
|
if pd.isna(field):
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
# Try to split multi-value field on "||" separator
|
2019-08-29 00:10:39 +02:00
|
|
|
|
for value in field.split("||"):
|
2021-01-03 14:30:03 +01:00
|
|
|
|
# Check if the current value is blank
|
|
|
|
|
if value == "":
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(
|
|
|
|
|
f"{Fore.RED}Unnecessary multi-value separator ({field_name}): {Fore.RESET}{field}"
|
|
|
|
|
)
|
2021-01-03 14:30:03 +01:00
|
|
|
|
|
|
|
|
|
continue
|
2019-07-26 22:48:24 +02:00
|
|
|
|
|
|
|
|
|
# After splitting, see if there are any remaining "|" characters
|
2019-08-29 00:10:39 +02:00
|
|
|
|
match = re.findall(r"^.*?\|.*$", value)
|
2019-07-26 22:48:24 +02:00
|
|
|
|
|
2021-01-03 14:30:03 +01:00
|
|
|
|
# Check if there was a match
|
2019-07-29 15:16:30 +02:00
|
|
|
|
if match:
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(
|
|
|
|
|
f"{Fore.RED}Invalid multi-value separator ({field_name}): {Fore.RESET}{field}"
|
|
|
|
|
)
|
2019-07-27 00:28:08 +02:00
|
|
|
|
|
|
|
|
|
return field
|
2019-07-28 15:11:36 +02:00
|
|
|
|
|
|
|
|
|
|
2019-08-21 14:31:12 +02:00
|
|
|
|
def date(field, field_name):
|
2019-07-28 15:11:36 +02:00
|
|
|
|
"""Check if a date is valid.
|
|
|
|
|
|
|
|
|
|
In DSpace the issue date is usually 1990, 1990-01, or 1990-01-01, but it
|
|
|
|
|
could technically even include time as long as it is ISO8601.
|
|
|
|
|
|
|
|
|
|
Also checks for other invalid cases like missing and multiple dates.
|
|
|
|
|
|
|
|
|
|
Prints the date if invalid.
|
|
|
|
|
"""
|
|
|
|
|
|
|
|
|
|
if pd.isna(field):
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(f"{Fore.RED}Missing date ({field_name}).{Fore.RESET}")
|
2019-07-28 15:11:36 +02:00
|
|
|
|
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
# Try to split multi-value field on "||" separator
|
2019-08-29 00:10:39 +02:00
|
|
|
|
multiple_dates = field.split("||")
|
2019-07-28 15:11:36 +02:00
|
|
|
|
|
|
|
|
|
# We don't allow multi-value date fields
|
|
|
|
|
if len(multiple_dates) > 1:
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(
|
|
|
|
|
f"{Fore.RED}Multiple dates not allowed ({field_name}): {Fore.RESET}{field}"
|
|
|
|
|
)
|
2019-07-28 15:11:36 +02:00
|
|
|
|
|
|
|
|
|
return field
|
|
|
|
|
|
|
|
|
|
try:
|
|
|
|
|
# Check if date is valid YYYY format
|
2019-08-29 00:10:39 +02:00
|
|
|
|
datetime.strptime(field, "%Y")
|
2019-07-28 15:11:36 +02:00
|
|
|
|
|
|
|
|
|
return field
|
|
|
|
|
except ValueError:
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
try:
|
|
|
|
|
# Check if date is valid YYYY-MM format
|
2019-08-29 00:10:39 +02:00
|
|
|
|
datetime.strptime(field, "%Y-%m")
|
2019-07-28 15:11:36 +02:00
|
|
|
|
|
|
|
|
|
return field
|
|
|
|
|
except ValueError:
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
try:
|
|
|
|
|
# Check if date is valid YYYY-MM-DD format
|
2019-08-29 00:10:39 +02:00
|
|
|
|
datetime.strptime(field, "%Y-%m-%d")
|
2019-07-28 15:11:36 +02:00
|
|
|
|
|
2021-02-04 20:39:14 +01:00
|
|
|
|
return field
|
|
|
|
|
except ValueError:
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
try:
|
|
|
|
|
# Check if date is valid YYYY-MM-DDTHH:MM:SSZ format
|
|
|
|
|
datetime.strptime(field, "%Y-%m-%dT%H:%M:%SZ")
|
|
|
|
|
|
2019-07-28 15:11:36 +02:00
|
|
|
|
return field
|
|
|
|
|
except ValueError:
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(f"{Fore.RED}Invalid date ({field_name}): {Fore.RESET}{field}")
|
2019-07-29 16:08:49 +02:00
|
|
|
|
|
2019-07-29 16:40:14 +02:00
|
|
|
|
return field
|
|
|
|
|
|
2019-07-29 16:08:49 +02:00
|
|
|
|
|
2019-08-09 00:22:59 +02:00
|
|
|
|
def suspicious_characters(field, field_name):
|
2019-07-29 16:08:49 +02:00
|
|
|
|
"""Warn about suspicious characters.
|
|
|
|
|
|
|
|
|
|
Look for standalone characters that could indicate encoding or copy/paste
|
|
|
|
|
errors for languages with accents. For example: foreˆt should be forêt.
|
|
|
|
|
"""
|
|
|
|
|
|
|
|
|
|
# Skip fields with missing values
|
|
|
|
|
if pd.isna(field):
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
# List of suspicious characters, for example: ́ˆ~`
|
2019-08-29 00:10:39 +02:00
|
|
|
|
suspicious_characters = ["\u00B4", "\u02C6", "\u007E", "\u0060"]
|
2019-07-29 16:08:49 +02:00
|
|
|
|
|
|
|
|
|
for character in suspicious_characters:
|
2019-08-09 00:22:59 +02:00
|
|
|
|
# Find the position of the suspicious character in the string
|
|
|
|
|
suspicious_character_position = field.find(character)
|
|
|
|
|
|
|
|
|
|
# Python returns -1 if there is no match
|
|
|
|
|
if suspicious_character_position != -1:
|
|
|
|
|
# Create a temporary new string starting from the position of the
|
|
|
|
|
# suspicious character
|
|
|
|
|
field_subset = field[suspicious_character_position:]
|
|
|
|
|
|
|
|
|
|
# Print part of the metadata value starting from the suspicious
|
|
|
|
|
# character and spanning enough of the rest to give a preview,
|
|
|
|
|
# but not too much to cause the line to break in terminals with
|
|
|
|
|
# a default of 80 characters width.
|
2021-02-21 12:01:25 +01:00
|
|
|
|
suspicious_character_msg = f"{Fore.YELLOW}Suspicious character ({field_name}): {Fore.RESET}{field_subset}"
|
2019-08-29 00:10:39 +02:00
|
|
|
|
print(f"{suspicious_character_msg:1.80}")
|
2019-07-29 16:08:49 +02:00
|
|
|
|
|
|
|
|
|
return field
|
2019-07-29 17:59:42 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def language(field):
|
2019-09-26 06:44:39 +02:00
|
|
|
|
"""Check if a language is valid ISO 639-1 (alpha 2) or ISO 639-3 (alpha 3).
|
2019-07-29 17:59:42 +02:00
|
|
|
|
|
|
|
|
|
Prints the value if it is invalid.
|
|
|
|
|
"""
|
|
|
|
|
|
|
|
|
|
# Skip fields with missing values
|
|
|
|
|
if pd.isna(field):
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
# need to handle "Other" values here...
|
|
|
|
|
|
|
|
|
|
# Try to split multi-value field on "||" separator
|
2019-08-29 00:10:39 +02:00
|
|
|
|
for value in field.split("||"):
|
2019-07-29 17:59:42 +02:00
|
|
|
|
|
|
|
|
|
# After splitting, check if language value is 2 or 3 characters so we
|
2019-09-26 06:44:39 +02:00
|
|
|
|
# can check it against ISO 639-1 or ISO 639-3 accordingly.
|
2019-07-29 17:59:42 +02:00
|
|
|
|
if len(value) == 2:
|
2019-07-30 15:39:26 +02:00
|
|
|
|
if not languages.get(alpha_2=value):
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(f"{Fore.RED}Invalid ISO 639-1 language: {Fore.RESET}{value}")
|
2019-07-29 17:59:42 +02:00
|
|
|
|
|
|
|
|
|
pass
|
|
|
|
|
elif len(value) == 3:
|
2019-07-30 15:39:26 +02:00
|
|
|
|
if not languages.get(alpha_3=value):
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(f"{Fore.RED}Invalid ISO 639-3 language: {Fore.RESET}{value}")
|
2019-07-29 17:59:42 +02:00
|
|
|
|
|
|
|
|
|
pass
|
|
|
|
|
else:
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(f"{Fore.RED}Invalid language: {Fore.RESET}{value}")
|
2019-07-29 17:59:42 +02:00
|
|
|
|
|
|
|
|
|
return field
|
2019-07-29 23:30:31 +02:00
|
|
|
|
|
|
|
|
|
|
2019-08-01 22:51:58 +02:00
|
|
|
|
def agrovoc(field, field_name):
|
2019-07-29 23:30:31 +02:00
|
|
|
|
"""Check subject terms against AGROVOC REST API.
|
|
|
|
|
|
2019-08-01 22:51:58 +02:00
|
|
|
|
Function constructor expects the field as well as the field name because
|
|
|
|
|
many fields can now be validated against AGROVOC and we want to be able
|
|
|
|
|
to inform the user in which field the invalid term is.
|
|
|
|
|
|
2019-07-29 23:30:31 +02:00
|
|
|
|
Logic copied from agrovoc-lookup.py.
|
|
|
|
|
|
|
|
|
|
See: https://github.com/ilri/DSpace/blob/5_x-prod/agrovoc-lookup.py
|
|
|
|
|
|
|
|
|
|
Prints a warning if the value is invalid.
|
|
|
|
|
"""
|
|
|
|
|
|
|
|
|
|
# Skip fields with missing values
|
|
|
|
|
if pd.isna(field):
|
|
|
|
|
return
|
|
|
|
|
|
2020-07-06 12:41:51 +02:00
|
|
|
|
# enable transparent request cache with thirty days expiry
|
|
|
|
|
expire_after = timedelta(days=30)
|
2021-03-14 08:07:35 +01:00
|
|
|
|
# Allow overriding the location of the requests cache, just in case we are
|
|
|
|
|
# running in an environment where we can't write to the current working di-
|
|
|
|
|
# rectory (for example from csv-metadata-quality-web).
|
|
|
|
|
REQUESTS_CACHE_DIR = os.environ.get("REQUESTS_CACHE_DIR", ".")
|
|
|
|
|
requests_cache.install_cache(f"{REQUESTS_CACHE_DIR}/agrovoc-response-cache", expire_after=expire_after)
|
2020-07-06 12:41:51 +02:00
|
|
|
|
|
|
|
|
|
# prune old cache entries
|
|
|
|
|
requests_cache.core.remove_expired_responses()
|
|
|
|
|
|
2019-07-29 23:30:31 +02:00
|
|
|
|
# Try to split multi-value field on "||" separator
|
2019-08-29 00:10:39 +02:00
|
|
|
|
for value in field.split("||"):
|
2020-07-06 12:44:46 +02:00
|
|
|
|
request_url = "http://agrovoc.uniroma2.it/agrovoc/rest/v1/agrovoc/search"
|
|
|
|
|
request_params = {"query": value}
|
2019-08-21 15:35:29 +02:00
|
|
|
|
|
2020-07-06 12:44:46 +02:00
|
|
|
|
request = requests.get(request_url, params=request_params)
|
2019-08-21 15:35:29 +02:00
|
|
|
|
|
|
|
|
|
if request.status_code == requests.codes.ok:
|
|
|
|
|
data = request.json()
|
|
|
|
|
|
|
|
|
|
# check if there are any results
|
2019-08-29 00:10:39 +02:00
|
|
|
|
if len(data["results"]) == 0:
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(f"{Fore.RED}Invalid AGROVOC ({field_name}): {Fore.RESET}{value}")
|
2019-07-29 23:30:31 +02:00
|
|
|
|
|
|
|
|
|
return field
|
2019-08-10 22:41:16 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def filename_extension(field):
|
|
|
|
|
"""Check filename extension.
|
|
|
|
|
|
|
|
|
|
CSVs with a 'filename' column are likely meant as input for the SAFBuilder
|
|
|
|
|
tool, which creates a Simple Archive Format bundle for importing metadata
|
|
|
|
|
with accompanying PDFs or other files into DSpace.
|
|
|
|
|
|
|
|
|
|
This check warns if a filename has an uncommon extension (that is, other
|
|
|
|
|
than .pdf, .xls(x), .doc(x), ppt(x), case insensitive).
|
|
|
|
|
"""
|
|
|
|
|
|
|
|
|
|
# Skip fields with missing values
|
|
|
|
|
if pd.isna(field):
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
# Try to split multi-value field on "||" separator
|
2019-08-29 00:10:39 +02:00
|
|
|
|
values = field.split("||")
|
2019-08-10 22:41:16 +02:00
|
|
|
|
|
|
|
|
|
# List of common filename extentions
|
2019-08-29 00:10:39 +02:00
|
|
|
|
common_filename_extensions = [
|
|
|
|
|
".pdf",
|
|
|
|
|
".doc",
|
|
|
|
|
".docx",
|
|
|
|
|
".ppt",
|
|
|
|
|
".pptx",
|
|
|
|
|
".xls",
|
|
|
|
|
".xlsx",
|
|
|
|
|
]
|
2019-08-10 22:41:16 +02:00
|
|
|
|
|
|
|
|
|
# Iterate over all values
|
|
|
|
|
for value in values:
|
|
|
|
|
# Assume filename extension does not match
|
|
|
|
|
filename_extension_match = False
|
|
|
|
|
|
|
|
|
|
for filename_extension in common_filename_extensions:
|
|
|
|
|
# Check for extension at the end of the filename
|
2019-08-29 00:10:39 +02:00
|
|
|
|
pattern = re.escape(filename_extension) + r"$"
|
2019-08-10 22:41:16 +02:00
|
|
|
|
match = re.search(pattern, value, re.IGNORECASE)
|
|
|
|
|
|
|
|
|
|
if match is not None:
|
|
|
|
|
# Register the match and stop checking for this filename
|
|
|
|
|
filename_extension_match = True
|
|
|
|
|
|
|
|
|
|
break
|
|
|
|
|
|
2019-08-10 22:52:53 +02:00
|
|
|
|
if filename_extension_match is False:
|
2021-02-21 12:01:25 +01:00
|
|
|
|
print(f"{Fore.YELLOW}Filename with uncommon extension: {Fore.RESET}{value}")
|
2019-08-10 22:41:16 +02:00
|
|
|
|
|
|
|
|
|
return field
|
2021-03-11 09:33:16 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def spdx_license_identifier(field):
|
|
|
|
|
"""Check if a license is a valid SPDX identifier.
|
|
|
|
|
|
|
|
|
|
Prints the value if it is invalid.
|
|
|
|
|
"""
|
|
|
|
|
|
|
|
|
|
# Skip fields with missing values
|
|
|
|
|
if pd.isna(field):
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
# Try to split multi-value field on "||" separator
|
|
|
|
|
for value in field.split("||"):
|
|
|
|
|
if value not in spdx_license_list.LICENSES:
|
|
|
|
|
print(f"{Fore.YELLOW}Non-SPDX license identifier: {Fore.RESET}{value}")
|
|
|
|
|
|
|
|
|
|
pass
|
|
|
|
|
|
|
|
|
|
return field
|