Update notes

This commit is contained in:
2018-02-19 23:15:24 +02:00
parent 4c0f0397a6
commit caee625afd
4 changed files with 82 additions and 14 deletions

View File

@ -672,3 +672,35 @@ $ cat output.txt
Ali Ramadhan: 0000-0001-5019-1368
Ahmad Maryudi: 0000-0001-5051-7217
```
- I was running this on the new list of 1571 and found an error:
```
Looking up the name associated with ORCID iD: 0000-0001-9634-1958
Traceback (most recent call last):
File "./resolve-orcids.py", line 111, in <module>
read_identifiers_from_file()
File "./resolve-orcids.py", line 37, in read_identifiers_from_file
resolve_orcid_identifiers(orcids)
File "./resolve-orcids.py", line 65, in resolve_orcid_identifiers
family_name = data['name']['family-name']['value']
TypeError: 'NoneType' object is not subscriptable
```
- According to ORCID that identifier's family-name is null so that sucks
- I fixed the script so that it checks if the family name is null
- Now another:
```
Looking up the name associated with ORCID iD: 0000-0002-1300-3636
Traceback (most recent call last):
File "./resolve-orcids.py", line 117, in <module>
read_identifiers_from_file()
File "./resolve-orcids.py", line 37, in read_identifiers_from_file
resolve_orcid_identifiers(orcids)
File "./resolve-orcids.py", line 65, in resolve_orcid_identifiers
if data['name']['given-names']:
TypeError: 'NoneType' object is not subscriptable
```
- According to ORCID that identifier's entire name block is null!