From 31c06c2da426e4b51c577f32477dbca0741d155d Mon Sep 17 00:00:00 2001
From: Alan Orth <alan.orth@gmail.com>
Date: Wed, 22 Aug 2018 01:42:03 +0300
Subject: [PATCH] Update notes for 2018-08-21

---
 content/posts/2018-08.md |  9 +++++++++
 docs/2018-08/index.html  | 16 +++++++++++++---
 docs/sitemap.xml         | 10 +++++-----
 3 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/content/posts/2018-08.md b/content/posts/2018-08.md
index b6f6b9691..324f0d587 100644
--- a/content/posts/2018-08.md
+++ b/content/posts/2018-08.md
@@ -236,6 +236,15 @@ Mozilla/5.0 (compatible; MegaIndex.ru/2.0; +http://megaindex.com/crawler)
 - ... it seems that the `atmire-module-upgrades-5.8` branch still takes 1 hour and 23 minutes on my local machine...
 - Let me try to build the old `5_x-prod-dspace-5.5` branch on my local machine and see how long it takes
 - That one only took 13 minutes! So there is definitely something wrong with our 5.8 branch, now I should try vanilla DSpace 5.8
+- I notice that the step this pauses at is:
+
+```
+[INFO] --- maven-war-plugin:2.4:war (default-war) @ xmlui ---
+```
+
+- And I notice that Atmire changed something in the XMLUI module's `pom.xml` as part of the DSpace 5.8 changes, specifically to remove the exclude for `node_modules` in the `maven-war-plugin` step
+- This exclude is *present* in vanilla DSpace, and if I add it back the build time goes from 1 hour 23 minutes to 12 minutes!
+- I need to test to see if this has any side effects when deployed...
 - In other news, I see there was a pull request in DSpace 5.9 that fixes the issue with not being able to have blank lines in CSVs when importing via command line or webui ([DS-3245](https://jira.duraspace.org/browse/DS-3245))
 
 <!-- vim: set sw=2 ts=2: -->
diff --git a/docs/2018-08/index.html b/docs/2018-08/index.html
index f5eba5a15..52000f7ed 100644
--- a/docs/2018-08/index.html
+++ b/docs/2018-08/index.html
@@ -34,7 +34,7 @@ I ran all system updates on DSpace Test and rebooted it
 
 <meta property="article:published_time" content="2018-08-01T11:52:54&#43;03:00"/>
 
-<meta property="article:modified_time" content="2018-08-21T22:39:00&#43;03:00"/>
+<meta property="article:modified_time" content="2018-08-22T00:38:23&#43;03:00"/>
 
 
 
@@ -79,9 +79,9 @@ I ran all system updates on DSpace Test and rebooted it
   "@type": "BlogPosting",
   "headline": "August, 2018",
   "url": "https://alanorth.github.io/cgspace-notes/2018-08/",
-  "wordCount": "1860",
+  "wordCount": "1945",
   "datePublished": "2018-08-01T11:52:54&#43;03:00",
-  "dateModified": "2018-08-21T22:39:00&#43;03:00",
+  "dateModified": "2018-08-22T00:38:23&#43;03:00",
   "author": {
     "@type": "Person",
     "name": "Alan Orth"
@@ -407,6 +407,16 @@ sys     2m20.248s
 <li>&hellip; it seems that the <code>atmire-module-upgrades-5.8</code> branch still takes 1 hour and 23 minutes on my local machine&hellip;</li>
 <li>Let me try to build the old <code>5_x-prod-dspace-5.5</code> branch on my local machine and see how long it takes</li>
 <li>That one only took 13 minutes! So there is definitely something wrong with our 5.8 branch, now I should try vanilla DSpace 5.8</li>
+<li>I notice that the step this pauses at is:</li>
+</ul>
+
+<pre><code>[INFO] --- maven-war-plugin:2.4:war (default-war) @ xmlui ---
+</code></pre>
+
+<ul>
+<li>And I notice that Atmire changed something in the XMLUI module&rsquo;s <code>pom.xml</code> as part of the DSpace 5.8 changes, specifically to remove the exclude for <code>node_modules</code> in the <code>maven-war-plugin</code> step</li>
+<li>This exclude is <em>present</em> in vanilla DSpace, and if I add it back the build time goes from 1 hour 23 minutes to 12 minutes!</li>
+<li>I need to test to see if this has any side effects when deployed&hellip;</li>
 <li>In other news, I see there was a pull request in DSpace 5.9 that fixes the issue with not being able to have blank lines in CSVs when importing via command line or webui (<a href="https://jira.duraspace.org/browse/DS-3245">DS-3245</a>)</li>
 </ul>
 
diff --git a/docs/sitemap.xml b/docs/sitemap.xml
index 4cdf0aa75..d50922132 100644
--- a/docs/sitemap.xml
+++ b/docs/sitemap.xml
@@ -4,7 +4,7 @@
   
   <url>
     <loc>https://alanorth.github.io/cgspace-notes/2018-08/</loc>
-    <lastmod>2018-08-21T22:39:00+03:00</lastmod>
+    <lastmod>2018-08-22T00:38:23+03:00</lastmod>
   </url>
   
   <url>
@@ -179,7 +179,7 @@
   
   <url>
     <loc>https://alanorth.github.io/cgspace-notes/</loc>
-    <lastmod>2018-08-21T22:39:00+03:00</lastmod>
+    <lastmod>2018-08-22T00:38:23+03:00</lastmod>
     <priority>0</priority>
   </url>
   
@@ -190,7 +190,7 @@
   
   <url>
     <loc>https://alanorth.github.io/cgspace-notes/tags/notes/</loc>
-    <lastmod>2018-08-21T22:39:00+03:00</lastmod>
+    <lastmod>2018-08-22T00:38:23+03:00</lastmod>
     <priority>0</priority>
   </url>
   
@@ -202,13 +202,13 @@
   
   <url>
     <loc>https://alanorth.github.io/cgspace-notes/posts/</loc>
-    <lastmod>2018-08-21T22:39:00+03:00</lastmod>
+    <lastmod>2018-08-22T00:38:23+03:00</lastmod>
     <priority>0</priority>
   </url>
   
   <url>
     <loc>https://alanorth.github.io/cgspace-notes/tags/</loc>
-    <lastmod>2018-08-21T22:39:00+03:00</lastmod>
+    <lastmod>2018-08-22T00:38:23+03:00</lastmod>
     <priority>0</priority>
   </url>