Revert "Only update packages indexes if the cache is 1 hour old"

This reverts commit 201165cff6.

Turns out this actually breaks initial deployments, because the
cache gets updated in the first task, then you add sources for
nginx and mariadb, but it doesn't update the indexes because the
cache is < 3600 seconds old, so you end up getting the distro's
versions of nginx and mariadb.

roles/common/tasks/iptables_Debian.yml

@@ -1,7 +1,7 @@
 ---
 - name: Install firewalld and deps
   when: ansible_distribution_major_version == '8'
-  apt: pkg={{ item }} state=latest update_cache=yes cache_valid_time=3600
+  apt: pkg={{ item }} state=latest
   with_items:
     - firewalld
     - tidy

roles/common/tasks/iptables_Ubuntu.yml

@@ -1,7 +1,7 @@
 ---
 - name: Install iptables-persistent
   when: ansible_distribution_version == '14.04'
-  apt: pkg=iptables-persistent update_cache=yes cache_valid_time=3600
+  apt: pkg=iptables-persistent update_cache=yes
   tags: packages
 
 - name: Copy /etc/iptables/rules.v4

roles/common/tasks/packages_Debian.yml

@@ -3,7 +3,7 @@
   template: src=sources.list.j2 dest=/etc/apt/sources.list owner=root group=root mode=0644
 
 - name: Install base packages
-  apt: name={{ item }} update_cache=yes cache_valid_time=3600
+  apt: name={{ item }} update_cache=yes
   with_items:
     - git
     - tmux

roles/common/tasks/packages_Ubuntu.yml

@@ -7,7 +7,7 @@
   when: ansible_distribution_version == '14.04'
 
 - name: Upgrade base OS
-  apt: upgrade=dist update_cache=yes cache_valid_time=3600
+  apt: upgrade=dist update_cache=yes
 
 - name: Install base packages
   apt: pkg={{ item }}

roles/mariadb/tasks/main.yml

@@ -15,7 +15,7 @@
   tags: mariadb, packages
 
 - name: Install mariadb-server
-  apt: name={{ item }} state=present update_cache=yes cache_valid_time=3600
+  apt: name={{ item }} state=present update_cache=yes
   with_items:
     - mariadb-server
     - python-mysqldb # for ansible

roles/nginx/tasks/main.yml

@@ -8,7 +8,7 @@
   tags: nginx, packages
 
 - name: Install nginx
-  apt: pkg=nginx update_cache=yes state=latest cache_valid_time=3600
+  apt: pkg=nginx update_cache=yes state=latest
   tags: nginx, packages
 
 - name: Copy nginx configs

roles/php-fpm/tasks/Debian.yml

@@ -1,6 +1,6 @@
 ---
 - name: Install php5-fpm and deps
-  apt: name={{ item }} state=present update_cache=yes cache_valid_time=3600
+  apt: name={{ item }} state=present update_cache=yes
   with_items:
     - php5-fpm
     # for WordPress

roles/php-fpm/tasks/Ubuntu.yml

@@ -1,6 +1,6 @@
 ---
 - name: Install php7.0-fpm and deps
-  apt: name={{ item }} state=present update_cache=yes cache_valid_time=3600
+  apt: name={{ item }} state=present update_cache=yes
   with_items:
     - php7.0-fpm
     # for WordPress