Update with_items loops to use new-ish "loop" keyword

Ansible 2.4 and 2.5 are moving away from specialized loop functions
and the old syntax will eventually be deprecated and removed. I did
not change the with_fileglob loops because I'm not sure about their
syntax yet.

See: https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html

roles/common/tasks/cron-apt.yml

@@ -2,7 +2,7 @@
 
 - name: Configure cron-apt (config)
   copy: src={{ item.src }} dest={{ item.dest }} mode={{ item.mode }} owner={{ item.owner }} group={{ item.group }}
-  with_items:
+  loop:
     - { src: 'etc/cron-apt/config', dest: '/etc/cron-apt/config', mode: '0644', owner: 'root', group: 'root' }
     - { src: 'etc/cron-apt/3-download', dest: '/etc/cron-apt/action.d/3-download', mode: '0644', owner: 'root', group: 'root' }
 

roles/common/tasks/firewall_Debian.yml

@@ -2,7 +2,7 @@
 - name: Install firewalld and deps
   when: ansible_distribution_major_version is version_compare('8', '>=')
   apt: pkg={{ item }} state=present
-  with_items:
+  loop:
     - firewalld
     - tidy
   tags: packages

roles/common/tasks/firewall_Ubuntu.yml

@@ -2,7 +2,7 @@
 - name: Install firewalld and deps
   when: ansible_distribution_version is version_compare('15.04', '>=')
   apt: pkg={{ item }} state=present
-  with_items:
+  loop:
     - firewalld
     - tidy
   tags: packages

roles/common/tasks/packages_Debian.yml

@@ -4,7 +4,7 @@
 
 - name: Install base packages
   apt: name={{ item }} update_cache=yes
-  with_items:
+  loop:
     - git
     - tmux
     - iotop

roles/common/tasks/packages_Ubuntu.yml

@@ -8,7 +8,7 @@
 
 - name: Install base packages
   apt: pkg={{ item }}
-  with_items:
+  loop:
     - git
     - tmux
     - iotop
@@ -29,13 +29,13 @@
 
 - name: Security hardening (CIS Benchmark 1.0)
   apt: pkg={{ item }} state=absent purge=yes
-  with_items:
+  loop:
     - whoopsie # CIS 4.1
     - apport   # CIS 4.1
 
 - name: Remove annoying packages
   apt: pkg={{ item }} state=absent purge=yes
-  with_items:
+  loop:
     - command-not-found
     - command-not-found-data
     - python3-commandnotfound

roles/common/tasks/sshd.yml

@@ -15,7 +15,7 @@
 
 - name: Remove DSA and ECDSA host keys
   file: name=/etc/ssh/{{ item }} state=absent
-  with_items:
+  loop:
     - ssh_host_dsa_key
     - ssh_host_dsa_key.pub
     - ssh_host_ecdsa_key